Skip to content

Commit

Permalink
Dockerfile: avoid using legacy key value format (axieinfinity#617)
Browse files Browse the repository at this point in the history
Change from ENV key value to ENV key=value format which is recommended in
Docker's documentation
(https://docs.docker.com/reference/build-checks/legacy-key-value-format/). This
commit also uppercases AS to match with FROM.
  • Loading branch information
minh-bq authored Oct 29, 2024
1 parent de528e0 commit 3c463cb
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 21 deletions.
38 changes: 19 additions & 19 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build Geth in a stock Go builder container
FROM golang:1.20.10-alpine3.18@sha256:0d6e012ec44ed21993ee2ccf05839844f13347165ce7599a8e8442b02f836b45 as builder
FROM golang:1.20.10-alpine3.18@sha256:0d6e012ec44ed21993ee2ccf05839844f13347165ce7599a8e8442b02f836b45 AS builder

RUN apk add --no-cache make gcc musl-dev linux-headers git libstdc++-dev

Expand All @@ -12,24 +12,24 @@ FROM alpine:3.18@sha256:5292533eb4efd4b5cf35e93b5a2b7d0e07ea193224c49446c7802c19
RUN apk add --no-cache ca-certificates
WORKDIR "/opt"

ENV PASSWORD ''
ENV PRIVATE_KEY ''
ENV BOOTNODES ''
ENV VERBOSITY 3
ENV SYNC_MODE 'snap'
ENV NETWORK_ID '2021'
ENV ETHSTATS_ENDPOINT ''
ENV NODEKEY ''
ENV FORCE_INIT 'true'
ENV RONIN_PARAMS ''
ENV INIT_FORCE_OVERRIDE_CHAIN_CONFIG 'false'
ENV ENABLE_FAST_FINALITY 'true'
ENV ENABLE_FAST_FINALITY_SIGN 'false'
ENV BLS_PRIVATE_KEY ''
ENV BLS_PASSWORD ''
ENV BLS_AUTO_GENERATE 'false'
ENV BLS_SHOW_PRIVATE_KEY 'false'
ENV GENERATE_BLS_PROOF 'false'
ENV PASSWORD=''
ENV PRIVATE_KEY=''
ENV BOOTNODES=''
ENV VERBOSITY=3
ENV SYNC_MODE='snap'
ENV NETWORK_ID='2021'
ENV ETHSTATS_ENDPOINT=''
ENV NODEKEY=''
ENV FORCE_INIT='true'
ENV RONIN_PARAMS=''
ENV INIT_FORCE_OVERRIDE_CHAIN_CONFIG='false'
ENV ENABLE_FAST_FINALITY='true'
ENV ENABLE_FAST_FINALITY_SIGN='false'
ENV BLS_PRIVATE_KEY=''
ENV BLS_PASSWORD=''
ENV BLS_AUTO_GENERATE='false'
ENV BLS_SHOW_PRIVATE_KEY='false'
ENV GENERATE_BLS_PROOF='false'

COPY --from=builder /opt/build/bin/ronin /usr/local/bin/ronin
COPY --from=builder /opt/genesis/ ./
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.alltools
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ ARG VERSION=""
ARG BUILDNUM=""

# Build Geth in a stock Go builder container
FROM golang:1.17-alpine as builder
FROM golang:1.17-alpine AS builder

RUN apk add --no-cache gcc musl-dev linux-headers git

Expand Down
2 changes: 1 addition & 1 deletion docker/bootnode/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build Geth in a stock Go builder container
FROM golang:1.15.5-alpine as builder
FROM golang:1.15.5-alpine AS builder

RUN apk add --no-cache make gcc musl-dev linux-headers git

Expand Down

0 comments on commit 3c463cb

Please sign in to comment.