This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
forked from andreknieriem/photobooth
-
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi34
reviewed
Jul 23, 2021
andi34
reviewed
Jul 23, 2021
Change-Id: I18d134e9900f2a99234d020bbece1ff3c06f5834
Change-Id: I36e8005794acdf90c245cbb0bdb011df0b0401fc
andi34
force-pushed
the
v3/feature/debugpanel
branch
from
July 24, 2021 09:44
16ecb43
to
9f9508d
Compare
andi34
reviewed
Jul 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the dumpfile function?
andi34
reviewed
Jul 29, 2021
Change-Id: Ib619c7f43902c08db2bcd38cafb68b5018d743f8
Looks good and great idea! Thanks! |
andi34
reviewed
Jul 30, 2021
echo '<li><a class="adminnavlistelement" href="#myconfig" id="nav-myconfig"><div><span data-i18n="myconfig">myconfig</span></div></a></li>'; | ||
echo '<li><a class="adminnavlistelement" href="#remotebuzzerlog" id="nav-remotebuzzerlog"><div><span data-i18n="remotebuzzer">remotebuzzer</span></div></a></li>'; | ||
echo '<li><a class="adminnavlistelement" href="#synctodrivelog" id="nav-synctodrivelog"><div><span data-i18n="synctodrive">synctodrive</span></div></a></li>'; | ||
echo '<li><a class="adminnavlistelement" href="#cameralog" id="nav-cameralog"><div><span data-i18n="cameralog">cameralog</span></div></a></li>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab vs spaces
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Implements a panel for to help debugging in case of issues. Focus is to be able to access through the browser key configuration and log files on the server side. This feature is 1) for fast and efficient debugging iterations and 2) also well positioned to help people with less experience on the server administration and Unix / Raspberry Pi OS side of things.
Access to the debug panel is available through the admin panel (switch to expert view) or via direct URL http://localhost/admin/debugpanel.php
In particular useful for looking at log-files during operations, the debug panel allows to activate auto refresh. This feature will reload current content every 1 second and also automatically scroll to the bottom of the content to see what has changed.
The debug panel is architected in a way that additional debug items can easily be added
UI : admin/debugpanel.php
EXE: api/serverInfo.php
Is there anything you'd like reviewers to focus on?