This repository has been archived by the owner on Aug 27, 2022. It is now read-only.
feature: New Collage layout #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alzo425 I've slightly adjusted your changes, hope that's ok |
Implementation by alzo425: alzo425/photobooth@90099f1 Adjustments: - Only use collage related changes. - Fixed spaces. - Adjusted config. - Fixed Windows compatibility. Change-Id: Ie371872e774a9cccf4da2cf507d929f1e55db177
andi34
force-pushed
the
feature/collage-layout
branch
from
5b2f6a9 to
ab67bd8
Compare
Change-Id: I666532f8d9ddbe69356d3935b3bbe4d86ab6ef7b
andi34
force-pushed
the
feature/collage-layout
branch
from
ab67bd8 to
a9c0e2f
Compare
Change-Id: I9739cb98735a89256cfffd5134b5dc7b8a93b117
Change-Id: Icfea70b2925a519db9a15531db57cbafd1dd9009
Change-Id: I4679880a2b97f7a0a5e90361347805ac0196ab6a
Frame applied to every picture
Frame applied once
|
Change-Id: I8eee49d2432e4ef66ffdb525a33361fa7162b81b
…nd image Change-Id: Ice486264d35a8a2c22f6e7cbb88c078a2a95fc9f
Change-Id: I03d2ef1a12fe7b0d3094f8cacf4117de1d90e755
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "x" next to an item)
What changes did you make? (Give an overview)
Implementation for collage layout options by alzo425: alzo425/photobooth@90099f1
Partially applied changes from @KH404: (andreknieriem#258)
Adjustments:
Is there anything you'd like reviewers to focus on?
Fix andreknieriem#164
Partially fixes #82
2x2
2x4
2x4 + background image