Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target temp: Fahrenheit steps only if the celsius whole number steps #26

Open
aa755 opened this issue May 18, 2020 · 2 comments · May be fixed by #30
Open

target temp: Fahrenheit steps only if the celsius whole number steps #26

aa755 opened this issue May 18, 2020 · 2 comments · May be fixed by #30
Labels
bug Something isn't working

Comments

@aa755
Copy link

aa755 commented May 18, 2020

Describe the bug
If you change temperature from T1'F to T2'F and the two values when converted to celsius and rounded to nearest whole number are equal, the change is a nop.

To Reproduce

  1. Set temperature to 82F. The AC unit shows 28C (which is 82F converted to celsius and rounded to nearest whole number)
  2. Set temperature to 83F and note that in a few seconds, homeassistant reverts to 82F. The display on the AC never changes. 83F also corresponds to 28F. So this was a nop.
  3. Set temperature to 84F. Now the AC display changes to 29F and the change sticks in homeassistant.

Expected behavior
The change to 83F in step 2 should not be a nop. When using the nethome app, the target temperature can be set to 83F when the unit is set to fahrenheit mode.
(Also, ideally, the AC unit should show the temperature in fahrenheit as is the case when using the nethome app in fahrenheit mode.)

Screenshots / Logs
If applicable, add screenshots or your home-assistant log file to help explain your problem.

Versions

  • Home Assistant version: 0.109.6
  • Midea integration version (commit hash): e601616

Additional context
Add any other context about the problem here.

@aa755 aa755 added the bug Something isn't working label May 18, 2020
@aa755
Copy link
Author

aa755 commented May 18, 2020

Perhaps the way to solve this problem is to change the upstream library to send commands to the cloud directly in Fahrenheit mode instead of converting to/from celcius. There is some work in the 7-temp-branch of the ruby library. There is also an issue here (yitsushi/midea-air-condition#7).
The last comment on the issue is after the last commit in the branch. So it seems that the problem mentioned in the comment (AC reverts to Celcius on any send command) is sill a problem.
@robp2175 did you have any luck directly talking to the cloud/device in fahrenheit units?

@aa755
Copy link
Author

aa755 commented May 21, 2020

For me, the main advantage of Fahrenheit is that it allows more finegrained control of temperature: in the nethome app, in both celcius and Fahrenheit mode you can only set a whole number value as temperature.

aa755 added a commit to aa755/midea-ac-py that referenced this issue Jun 8, 2020
needs midea-ac-lib version d018cc32473bfece1ab6a5a09c522d9ee6394189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant