Conv layer #1
Merged
Conv layer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -120,6 +120,7 @@ def numpy_extensions(): | |||
| description='CUDA-based Numpy array and operations', | |||
| license='MIT', | |||
| url='http://compute.dtu.dk/~abll', | |||
| include_dirs=[numpy.get_include()], | |||
There was a problem hiding this comment.
Is this necessary? I have already added include dirs to the cythonize function.
There was a problem hiding this comment.
I could not compile unless that line was in
On Mon, Oct 6, 2014 at 4:20 PM, Anders Boesen Lindbo Larsen <
[email protected]> wrote:
In setup.py:
@@ -120,6 +120,7 @@ def numpy_extensions():
description='CUDA-based Numpy array and operations',
license='MIT',
url='http://compute.dtu.dk/~abll',
- include_dirs=[numpy.get_include()],
Is this necessary? I have already added include dirs to the cythonize
function.—
Reply to this email directly or view it on GitHub
https://github.com/andersbll/cudarray/pull/1/files#r18458742.
|
ready for merge when you are sure that the change in setup.py is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Conv layer and POOL layer for max and avg.