Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160918977 modify template source images #30

Merged
merged 1 commit into from
Oct 2, 2018
Merged

#160918977 modify template source images #30

merged 1 commit into from
Oct 2, 2018

Conversation

philophilo
Copy link
Contributor

What does this PR do?

  • Uses image url for templates' source image

Any background context you want to provide?

  • With the change to terraform google provider , an instance template can only pick the image only when given the full path

What are the relevant pivotal tracker stories?

160918977

@philophilo
chore(templates): modify source images
4038c57 
Use image url for templates' source image
Abstract images urls to variables

[Deliverrs #160918977]
@philophilo philophilo requested a review from Davitron October 2, 2018 17:08
Davitron
Davitron approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@Davitron Davitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philophilo philophilo merged commit 66fe9d2 into sandbox Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davitron Davitron Davitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philophilo @Davitron