This repository has been archived by the owner on Dec 11, 2024. It is now read-only.
fix(YouTube - Searchbar): Restore original settings page if query is empty #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
here's the things that still needs to be addressed:
|
Francesco146
changed the title
Francesco146
changed the title
|
after some consideration, maybe it's best to merge now and do the remaining features in other PRs |
anddea
pushed a commit
that referenced
this pull request
May 21, 2024
# [0.152.0-dev.12](v0.152.0-dev.11...v0.152.0-dev.12) (2024-05-21) ### Bug Fixes * **YouTube - Searchbar:** Hide searchbar in RYD and Sponsorblock sections ([#13](#13)) ([ed60bea](ed60bea)) * **YouTube - Searchbar:** Prevent searchbar appearing briefly when switching between fragments ([#14](#14)) ([584e6e3](584e6e3)) * **YouTube - Searchbar:** Restore original settings page if query is empty ([#12](#12)) ([9592bd5](9592bd5)) ### Features * **YouTube - Settings:** Add ability to search in summaries and list entries ([fbe9e53](fbe9e53))
anddea
pushed a commit
that referenced
this pull request
May 29, 2024
# [0.152.0](v0.151.0...v0.152.0) (2024-05-29) ### Bug Fixes * App crashes when resource not found ([6abcabc](6abcabc)) * **YouTube - Append timestamp information:** Ensure correct RTL layout ([027b948](027b948)) * **YouTube - Default video quality:** Revert back ([d6da339](d6da339)) * **YouTube - Hide action buttons:** Some action buttons are not hidden properly ([c37f238](c37f238)) * **YouTube - Hide feed components:** `Hide mix playlists` setting hides components in channel profile ([dc151ae](dc151ae)) * **YouTube - Hide keyword content:** Filter Shorts found in horizontal shelves ([25465e2](25465e2)) * **YouTube - Hide Shorts components:** Channel headers were hidden if Shorts is disabled ([5451719](5451719)) * **YouTube - Hide Shorts components:** Exclude `Hide sound metadata label` and `Hide video link label` from `Hide info panel` ([a510788](a510788)) * **YouTube - Hide Shorts components:** Hide Shorts in search result horizontal shelves ([2be49fc](2be49fc)) * **YouTube - Return YouTube Dislike:** Disabling `Show dislikes in Shorts` disabled dislikes everywhere ([#11](#11)) ([1b317db](1b317db)) * **YouTube - Return YouTube Dislike:** Dislike counts showing in views ([83bf7b2](83bf7b2)) * **YouTube - Return YouTube Dislike:** Fix some issues ([281dbe3](281dbe3)) * **YouTube - Return YouTube Dislike:** Subscribe icon is hidden ([95b34d4](95b34d4)) * **YouTube - Searchbar:** Hide searchbar in RYD and Sponsorblock sections ([#13](#13)) ([ed60bea](ed60bea)) * **YouTube - Searchbar:** Prevent searchbar appearing briefly when switching between fragments ([#14](#14)) ([584e6e3](584e6e3)) * **YouTube - Searchbar:** Restore original settings page if query is empty ([#12](#12)) ([9592bd5](9592bd5)) * **YouTube - Shorts components:** Update pattern for hide disabled comments ([c7b2fd4](c7b2fd4)) * **YouTube - SponsorBlock:** `Submit a new segment` button did not work ([395d3ce](395d3ce)) * **YouTube - SponsorBlock:** Pressing Now while manually editing a segment results in an error ([9521baa](9521baa)) * **YouTube - Spoof format stream data:** Some Uris are not hooked ([7e49ab3](7e49ab3)) * **YouTube - Video playback:** Default video quality sometimes does not apply when video is not loaded ([86b8130](86b8130)) * **YouTube Music/Hide ads:** `Hide fullscreen ads` setting also closes non-ad dialogs inotia00/ReVanced_Extended#1971 ([7dd292d](7dd292d)) * **YouTube/Description components:** crash occurs when the title of the engagement panel is null inotia00/ReVanced_Extended#2008 ([e4ba2d0](e4ba2d0)) * **YouTube/Hide layout components:** add method to hide settings with whitelist inotia00/ReVanced_Extended#1964 ([10e5d1a](10e5d1a)) * **YouTube/Return YouTube Dislike:** dislike count sometimes not shown in Shorts inotia00/ReVanced_Extended#1565 ([f869a37](f869a37)) * **YouTube/Return YouTube Dislike:** wrong video id is used in shorts inotia00/ReVanced_Extended#1987 ([3868c2b](3868c2b)) * **YouTube/Settings:** settings values of excluded patches have changed due to incorrect settings alignment ([d706d1b](d706d1b)) * **YouTube/SponsorBlock:** pressing the fine adjustment buttons skips to the end of the video while creating a new SponsorBlock segment inotia00/ReVanced_Extended#1980 ([f683045](f683045)) * **YouTube/Spoof format stream data:** check audio tags first ([75e84a2](75e84a2)) * **YouTube/Spoof format stream data:** incorrect url is used ([2f86f6b](2f86f6b)) * **YouTube/Video playback:** default video quality applies even when video is playing inotia00/ReVanced_Extended#1959 ([5cc2c04](5cc2c04)) * **YouTube:** App crashes when `SponsorBlock` patch is excluded ([e657bbd](e657bbd)) * **YT Music - Hide terms container:** Patch doesn't require restart to apply the changes ([e987b6d](e987b6d)) ### Features * Refactor and match ReVanced and inotia ([30ad38a](30ad38a)) * **YouTube - Fullscreen components:** `Hide related videos in quick actions` setting has been merged into the `Hide related video overlay` setting ([a9b973b](a9b973b)) * **YouTube - Hide layout components:** Add `Hide videos based on duration` ([b6bd93a](b6bd93a)) * **YouTube - Hide layout components:** Add an option to hide videos with views greater than specified value ([14d4756](14d4756)) * **YouTube - Hide shorts components:** Add separate option to hide in player ([67cfeb8](67cfeb8)) * **YouTube - Hide shorts components:** Hide comments button if disabled or with label "0" ([44f3c2f](44f3c2f)) * **YouTube - Overlay buttons:** Add `Whitelist` overlay button ([564a044](564a044)) * **YouTube - Player components:** Add setting toggle for `Hide suggested video end screen` ([d020bc8](d020bc8)) * **YouTube - Settings:** Add ability to search in summaries and list entries ([fbe9e53](fbe9e53)) * **YouTube - Settings:** Add search bar for settings ([681cea9](681cea9)) * **YouTube - Toolbar components:** Remove `Hide trending searches` setting ([b14f20c](b14f20c)) * **YouTube Music - Player components:** Add `Enable black player background` setting ([d27d362](d27d362)) * **YouTube Music - Player components:** Add `Hide audio video switch toggle` setting ([68238da](68238da)) * **YouTube/Spoof format stream data:** check endpoint url is non-null ([a25d7d7](a25d7d7)) * **YouTube/Spoof format stream data:** improve hook method, fetch to `ANDROID_TESTSUITE` client ([ef50cf5](ef50cf5)) * **YouTube:** Add `Hide videos by duration` and `Hide videos by views count` greater than specified value ([ReVanced#37](https://github.com/anddea/revanced-integrations/issues/37)) ([d15028c](d15028c)) * **YouTube:** Add `Spoof client` patch ([010f879](010f879)) * **YouTube:** Add support versions `19.19.39` - `19.20.34` ([3c4ccc3](3c4ccc3)) * **YouTube:** Hide live chat replay in fullscreen ([e8184a1](e8184a1)) * **YouTube:** Remove `Spoof test client` patch ([782b25b](782b25b)) ### Reverts * default landscape mode timeout ([f46db5d](f46db5d))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if the searchbar is empty after searching something it returns a plain list of all the settings. it should restore the page as if the user never searched a thing, so with all the settings in their respective categories.