feat(YouTube - Hide shorts components): Add separate option to hide i…

…n player
anddea · May 3, 2024 · 67cfeb8 · 67cfeb8
1 parent 9f0636e
commit 67cfeb8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/src/main/java/app/revanced/integrations/youtube/patches/components/ShortsFilter.java b/app/src/main/java/app/revanced/integrations/youtube/patches/components/ShortsFilter.java
@@ -295,6 +295,7 @@ private static boolean shouldHideShortsFeedItems() {
         final boolean hideHome = SettingsEnum.HIDE_SHORTS_HOME.getBoolean();
         final boolean hideSubscriptions = SettingsEnum.HIDE_SHORTS_SUBSCRIPTIONS.getBoolean();
         final boolean hideSearch = SettingsEnum.HIDE_SHORTS_SEARCH.getBoolean();
+        final boolean hidePlayer = SettingsEnum.HIDE_SHORTS_PLAYER.getBoolean();
 
         if (hideHome && hideSubscriptions && hideSearch) {
             // Shorts suggestions can load in the background if a video is opened and
@@ -311,7 +312,7 @@ private static boolean shouldHideShortsFeedItems() {
         // Must check player type first, as search bar can be active behind the player.
         if (PlayerType.getCurrent().isMaximizedOrFullscreen()) {
             // For now, consider the under video results the same as the home feed.
-            return hideHome;
+            return hidePlayer;
         }
 
         if (NavigationBar.isSearchBarActive()) { // Must check search first.

diff --git a/app/src/main/java/app/revanced/integrations/youtube/settings/SettingsEnum.java b/app/src/main/java/app/revanced/integrations/youtube/settings/SettingsEnum.java
@@ -384,6 +384,7 @@ public enum SettingsEnum {
     HIDE_SHORTS_HOME("revanced_hide_shorts_shelf_home", BOOLEAN, TRUE, parents(HIDE_SHORTS_SHELF)),
     HIDE_SHORTS_SEARCH("revanced_hide_shorts_shelf_search", BOOLEAN, TRUE, parents(HIDE_SHORTS_SHELF)),
     HIDE_SHORTS_SUBSCRIPTIONS("revanced_hide_shorts_shelf_subscriptions", BOOLEAN, TRUE, parents(HIDE_SHORTS_SHELF)),
+    HIDE_SHORTS_PLAYER("revanced_hide_shorts_shelf_player", BOOLEAN, TRUE, parents(HIDE_SHORTS_SHELF)),
 
     // Experimental Flags
     HIDE_SHORTS_PLAYER_NAVIGATION_BAR("revanced_hide_shorts_player_navigation_bar", BOOLEAN, FALSE, true),