fix: replace pkg_resources.get_distribution #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `pkg_resources.get_distribution` with the recommendation from `importlib_metadata` (per https://importlib-metadata.readthedocs.io/en/latest/migration.html#pkg-resources-get-distribution); however, the string output of the Distribution object has changed, so this makes the version output match what it was before using the new Distribution object. Signed-off-by: Weston Steimel <[email protected]>
westonsteimel
force-pushed
the
remove-pkg_resources-useage
branch
from
e3f213f to
e2ba25d
Compare
willmurphyscode
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
pkg_resources.get_distributionwith the recommendation fromimportlib_metadata(per https://importlib-metadata.readthedocs.io/en/latest/migration.html#pkg-resources-get-distribution); however, the string output of the Distribution object has changed, so this makes the version output match what it was before using the new Distribution object.This allows yardstick to work with python 3.12+ where
pkg_resourceshas been removed