Capture file ownership relationships from portage ecosystem #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-more-owned-file-pkgs
branch
from
709cd78 to
1685ce3
Compare
# $ diff schema/json/schema-7.0.1.json schema/json/schema-7.1.0.json
857,862d856
< "files": {
< "items": {
< "type": "string"
< },
< "type": "array"
< },
|
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-more-owned-file-pkgs
branch
from
53ed03c to
40bcdfa
Compare
kzantow
approved these changes
Apr 3, 2023
This was referenced Apr 6, 2023
This was referenced Apr 17, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…1702) * add portage as file owners Signed-off-by: Alex Goodman <[email protected]> * fix tests Signed-off-by: Alex Goodman <[email protected]> * fix linting Signed-off-by: Alex Goodman <[email protected]> * update json schema with NPM files Signed-off-by: Alex Goodman <[email protected]> --------- Signed-off-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to close the gap in terms of existing catalogers that already catalog paths to owned files and the generation of package-to-file relationships .
I also found:
Filesattribute for the NPMPackageJSONMetadata was not being used (and the Description was not being wired up). this requires a schema update (addition)Question: if there is a breaking schema change, why is this not accounted for in the new schema version (we're bumping from v7.0.1 to v7.1.0 instead of v8.0.0). Answer: this field was never populated, thus, no consumer could have been relying on data from syft in this attribute. This is pragmatically non-breaking.