feat: add identifiable field to source object #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow source.Source struct to set reproducable id for different scheme. This ID is calcuated either as a digest from the given directory or file path. If the scheme is detected to be an ImageScheme then the ID is calculated as a ChainID: https://github.com/opencontainers/image-spec/blob/main/config.md#layer-chainid Signed-off-by: Christopher Phillips <[email protected]>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
spiffcs
commented
Oct 4, 2022
syft/source/source.go
Outdated
| func (s *Source) SetID() { | ||
| if s.Metadata.Scheme != ImageScheme { | ||
| // How do we generate ID for non-image sources? | ||
| s.id = digest.FromString(s.Metadata.Path).String() |
There was a problem hiding this comment.
No path digest here: I think we want what's seen here
https://github.com/anchore/syft/pull/1218/files#diff-b79b344d258161c0ca7b6347af27d5ed643fdb01f4fbe654a69a688efe6a97cf
Getting a sum from the file itself or the metadata from the dir
lumjjb
reviewed
Oct 4, 2022
Signed-off-by: Christopher Phillips <[email protected]>
Signed-off-by: Christopher Phillips <[email protected]>
[optional footer(s)] Signed-off-by: Christopher Phillips <[email protected]>
kzantow
approved these changes
Oct 5, 2022
| return s.id | ||
| } | ||
|
|
||
| func (s *Source) SetID() { |
There was a problem hiding this comment.
Should this PR include a call to this function?
There was a problem hiding this comment.
^ Second PR is going to do that so we can link it into relationships - Just wanted to keep this PR small, but I can add the call so we're setting it on construction
There was a problem hiding this comment.
Looking again, there also isn't ONE great place to put the single call since we have functions like New, NewFromImage NewFromDirectory NewFromFile.
Let me see all the places it needs to be included so we have full coverage of all the source creation
There was a problem hiding this comment.
I could just have it get set on the first call to ID if s.id = ""
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
added a commit
to cpendery/syft
that referenced
this pull request
Oct 11, 2022
* main: refactor: Remove experimental Anchore Enterprise upload functionality (anchore#1257) Update syft bootstrap tools to latest versions. (anchore#1254) Update Stereoscope to d24c9d626b33fa720210b007a20767801827b532 (anchore#1253) Update syft bootstrap tools to latest versions. (anchore#1244) fix apkdb checksum representation (anchore#1247) feat: add identifiable field to source object (anchore#1243) feat: attest support for Singularity images (anchore#1201) Update syft bootstrap tools to latest versions. (anchore#1239) Update Stereoscope to 1b1b744a919964f38d14e1416fb3f25221b761ce (anchore#1240) fix: Follow symlinks when searching for globs in all-layers scope (anchore#1221)
spiffcs
added a commit
that referenced
this pull request
Oct 13, 2022
* main: (45 commits) feat: add RelationshipsBySourceOwnership to syft json output (#1248) fix: reset merged package into map; (#1258) refactor: Remove experimental Anchore Enterprise upload functionality (#1257) Update syft bootstrap tools to latest versions. (#1254) Update Stereoscope to d24c9d626b33fa720210b007a20767801827b532 (#1253) Update syft bootstrap tools to latest versions. (#1244) fix apkdb checksum representation (#1247) feat: add identifiable field to source object (#1243) feat: attest support for Singularity images (#1201) Update syft bootstrap tools to latest versions. (#1239) Update Stereoscope to 1b1b744a919964f38d14e1416fb3f25221b761ce (#1240) fix: Follow symlinks when searching for globs in all-layers scope (#1221) update requires to use list; remove field (#1234) Add Conan (C/C++) conan.lock file support (#1230) add sequence diagrams and flesh out TODO notes (#1233) Do not fail if unable to parse `.rpm` file (#1232) fix: support exclude patterns on Windows (#1228) Update syft bootstrap tools to latest versions. (#1225) Update Stereoscope to 56552770e555d764ea72b99d3c810326b27ead4a (#1224) Update syft bootstrap tools to latest versions. (#1223) ... Signed-off-by: Christopher Phillips <[email protected]>
aiwantaozi
pushed a commit
to aiwantaozi/syft
that referenced
this pull request
Oct 20, 2022
spiffcs
added a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Christopher Phillips <[email protected]>
spiffcs
added a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Christopher Phillips <[email protected]>
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow source.Source struct to set reproducible id for the following scheme:
This ID is calculated in the following ways:
Followups coming in separate smaller PR:
Signed-off-by: Christopher Phillips [email protected]