Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont attempt to notarize unsigned binaries #41

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Apr 11, 2023

Quill now checks to see if a binary is signed or not before attempting to notarize.

Screenshot 2023-04-11 at 5 33 42 PM

Closes #14

@wagoodman wagoodman force-pushed the dont-notarize-unsigned-binaries branch from 7189ad7 to 04a8878 Compare April 11, 2023 21:31
@wagoodman wagoodman marked this pull request as ready for review April 11, 2023 21:34
@wagoodman wagoodman enabled auto-merge (squash) April 11, 2023 21:34
@wagoodman wagoodman requested a review from a team April 11, 2023 21:34
Signed-off-by: Alex Goodman <[email protected]>
Copy link
Contributor

@spiffcs spiffcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after sync review

@wagoodman wagoodman merged commit 61979b7 into main Apr 12, 2023
@wagoodman wagoodman deleted the dont-notarize-unsigned-binaries branch April 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't attempt to notarize unsigned binaries
2 participants