Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use timestamp from only provider if only one provider #445

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

willmurphyscode
Copy link
Contributor

@willmurphyscode willmurphyscode commented Dec 2, 2024

Because building the NVD provider is unreliable right now, normally grype-db won't consider the NVD time as the earliest timestamp. However, if NVD is the only provider, report it anyway, because otherwise single-provider grype-db builds always fail for NVD.

This is meant to fix errors like this one: https://github.com/anchore/vunnel/actions/runs/12112985815/job/33767270739#step:4:2298

Because building the NVD provider is unreliable right now, normally
grype-db won't consider the NVD time as the earliest timestamp. However,
if NVD is the only provider, report it anyway, because otherwise
single-provider grype-db builds always fail for NVD.

Signed-off-by: Will Murphy <[email protected]>
@willmurphyscode willmurphyscode merged commit df14744 into main Dec 2, 2024
12 checks passed
@willmurphyscode willmurphyscode deleted the fix-nvd-timestamp-if-sole-provider branch December 2, 2024 13:50
wagoodman added a commit that referenced this pull request Dec 2, 2024
Signed-off-by: Alex Goodman <[email protected]>
wagoodman added a commit that referenced this pull request Dec 4, 2024
Signed-off-by: Alex Goodman <[email protected]>
wagoodman added a commit that referenced this pull request Dec 4, 2024
* enable packaging v6 DBs

Signed-off-by: Alex Goodman <[email protected]>

* moderate review comments

Signed-off-by: Alex Goodman <[email protected]>

* port fix from #445

Signed-off-by: Alex Goodman <[email protected]>

---------

Signed-off-by: Alex Goodman <[email protected]>
@wagoodman wagoodman added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants