Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI log level should override env var log level #31

Merged
merged 1 commit into from
Mar 25, 2022
Merged

CLI log level should override env var log level #31

merged 1 commit into from
Mar 25, 2022

Conversation

wagoodman
Copy link
Contributor

If you have a config where log.level is set and you provide -vv chronicle would error out. The correct behavior is to honor the cli option (which should override env vars and config files)

@wagoodman wagoodman changed the title Cli log level should override env var log level CLI log level should override env var log level Mar 25, 2022
@wagoodman wagoodman added the bug Something isn't working label Mar 25, 2022
@wagoodman wagoodman enabled auto-merge (squash) March 25, 2022 15:06
@wagoodman wagoodman disabled auto-merge March 25, 2022 16:00
@wagoodman wagoodman changed the title CLI log level should override env var log level cli log level should override env var log level Mar 25, 2022
@wagoodman wagoodman merged commit 64ff239 into main Mar 25, 2022
@wagoodman wagoodman deleted the cli-override-config-log-level branch March 25, 2022 16:01
@wagoodman wagoodman changed the title cli log level should override env var log level CLI log level should override env var log level Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wagoodman