init: allow force loading of extra modules via the kernel command-line #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatol
reviewed
Sep 26, 2022
| @@ -129,6 +129,7 @@ Some parts of booster boot functionality can be modified with kernel boot parame | |||
| If debug level is enabled then kmsg throttling gets disabled automatically. | |||
| * `booster.debug` an obsolete option that is equivalent to `booster.log=debug,console`. | |||
| * `quiet` Set booster init verbosity to minimum. This option is ignored if `booster.debug` or `booster.log` is set. | |||
| * `modules` a comma-separated list of extra kernel modules which should be force loaded. | |||
There was a problem hiding this comment.
what parameter name is used by other initramfs? I vaguely remember dracut likes to use rd. prefix for the parameters used by initramfs only.
There was a problem hiding this comment.
- Alpine's mkinitfs uses
modules, which is why I ended up using it here as well but I also wouldn't mind using something else of cause - dracut seems to distinguish
rd.driver.preandrd.driver.post: https://github.com/dracutdevs/dracut/blob/master/man/dracut.cmdline.7.asc#misc - mkinitcpio seems to use
earlymodules: https://wiki.archlinux.org/title/Mkinitcpio#init_from_base_hook
There was a problem hiding this comment.
I propose to use the dracut's idea with rd. prefix for initrd-specific parameters. I am going to merge your change to wip and modify the parameter name.
There was a problem hiding this comment.
Or maybe even call it rd.modules_force_load to match the name to config option that does the same.
nmeum
force-pushed
the
modules-cmdline
branch
from
5676e22
to
4a31eb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186