Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning instead of IndexOutOfBoundsException #786

Merged
merged 7 commits into from
Dec 9, 2023
Merged

Warning instead of IndexOutOfBoundsException #786

merged 7 commits into from
Dec 9, 2023

Conversation

anatawa12
Copy link
Owner

Fixes #770

@anatawa12 anatawa12 added the improvement improvements but not treated as feature in semver label Dec 9, 2023
@anatawa12 anatawa12 changed the base branch from master to master-1.6 December 9, 2023 09:08
@Sayamame-beans
Copy link
Collaborator

ちょっとしっくりこない感じはありますが、多分良いんじゃないかなぁと思っています

@anatawa12 anatawa12 marked this pull request as ready for review December 9, 2023 10:41
Sayamame-beans
Sayamame-beans approved these changes Dec 9, 2023
View reviewed changes
Localization/en.po Outdated Show resolved Hide resolved
@anatawa12 anatawa12 enabled auto-merge December 9, 2023 10:49
@anatawa12 anatawa12 merged commit 14c0158 into master-1.6 Dec 9, 2023
5 checks passed
@anatawa12 anatawa12 deleted the fix-index-out-of-bounds branch December 9, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
improvement improvements but not treated as feature in semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

アバター側がおかしいときにわかりやすくする
2 participants
@anatawa12 @Sayamame-beans