Add VRCSDK version defines to asmdefs and code generators #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikoga
force-pushed
the
vrcsdk_version_defines
branch
from
38958d2 to
5eb6e62
Compare
kaikoga
force-pushed
the
vrcsdk_version_defines
branch
from
5eb6e62 to
c74b962
Compare
kaikoga
force-pushed
the
vrcsdk_version_defines
branch
from
c74b962 to
07fbfde
Compare
anatawa12
approved these changes
Oct 17, 2023
| @@ -27,6 +36,8 @@ generate("SkinnedMeshRenderer") | |||
| generate("MeshRenderer") | |||
| generate("Material") | |||
| generate("String") | |||
| generate("VRCPhysBoneBase") | |||
| conditional(AAO_VRCSDK3_AVATARS, () => { | |||
There was a problem hiding this comment.
VRCPhysBoneってちょくせつさんしょうしてるぶぶんってあんまおおくなかったと思うのでfqnameでも良さそうではあるけどまぁ今後検討
そもそも2019 dropしたらこのファイルいらなくなる予定だし
enitimeago
added a commit
to enitimeago/make-it-mmd
that referenced
this pull request
Jan 17, 2024
This is similar to bdunderscore/modular-avatar#504 and anatawa12/AvatarOptimizer#609 which are motivated by supporting non-VRChat avatars. There are no immediate plans on my end to add non-VRChat avatar support yet, but I intend to pull in code from these repositories where appropriate, and this would make syncing with upstream easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #607
Note: I have excluded
.MergePhysBoneEditorModificationUtils.tsfrom this PR because I should deal withMergePhysBoneEditorModificationUtils.cssimultaneously, and these would be completely ignored by#if AAO_VRCSDK3_AVATARSanyway.