chore: add NotKeyable to every components

CHANGELOG-PRERELEASE.md

@@ -10,6 +10,8 @@ The format is based on [Keep a Changelog].
 ### Added
 
 ### Changed
+- You now cannot key any of AvatarOptimizer Components `#551`
+  - Previously you can key AvatarOptimizer Coponent but it was meaningless.
 
 ### Deprecated
 

CHANGELOG.md

@@ -11,6 +11,8 @@ The format is based on [Keep a Changelog].
 - Feature for debugging GC Objects `#543`
 
 ### Changed
+- You now cannot key any of AvatarOptimizer Components `#551`
+  - Previously you can key AvatarOptimizer Coponent but it was meaningless.
 
 ### Deprecated
 

Internal/PrefabSafeSet/Runtime/PrefabSafeSet.cs

@@ -4,6 +4,7 @@
 using System.Reflection;
 using JetBrains.Annotations;
 using UnityEngine;
+using UnityEngine.Animations;
 using Object = UnityEngine.Object;
 
 namespace Anatawa12.AvatarOptimizer.PrefabSafeSet
@@ -58,7 +59,7 @@ public static MethodInfo GetOnBeforeSerializeCallbackMethod(Type tType, Type tLa
     /// </summary>
     /// <typeparam name="T">Element Type</typeparam>
     /// <typeparam name="TLayer">Layer Type</typeparam>
-    [Serializable]
+    [NotKeyable, Serializable]
     public class PrefabSafeSet<T, TLayer> : ISerializationCallbackReceiver where TLayer : PrefabLayer<T>, new()
     {
         [SerializeField] internal T[] mainSet = Array.Empty<T>();

Runtime/AvatarTagComponent.cs

@@ -1,6 +1,7 @@
 using System;
 using Anatawa12.AvatarOptimizer.ErrorReporting;
 using UnityEngine;
+using UnityEngine.Animations;
 using VRC.SDKBase;
 
 namespace Anatawa12.AvatarOptimizer

Runtime/ClearEndpointPosition.cs

@@ -1,11 +1,13 @@
 using UnityEngine;
+using UnityEngine.Animations;
 using VRC.Dynamics;
 
 namespace Anatawa12.AvatarOptimizer
 {
     [AddComponentMenu("Avatar Optimizer/AAO Clear Endpoint Position")]
     [RequireComponent(typeof(VRCPhysBoneBase))]
     [DisallowMultipleComponent]
+    [NotKeyable]
     [HelpURL("https://vpm.anatawa12.com/avatar-optimizer/ja/docs/reference/clear-endpoint-position/")]
     internal class ClearEndpointPosition : AvatarTagComponent
     {

Runtime/FreezeBlendShape.cs

@@ -1,5 +1,6 @@
 using System.Collections.Generic;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {

Runtime/InternalAutoFreezeMeaninglessBlendShape.cs

@@ -1,12 +1,14 @@
 using System.Collections.Generic;
 using JetBrains.Annotations;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
     // TODO move to somewhere else? e.g. in editor module if possible
     [AddComponentMenu("")]
     [DisallowMultipleComponent]
+    [NotKeyable]
     internal class InternalAutoFreezeMeaninglessBlendShape : EditSkinnedMeshComponent
     {
         [CanBeNull] internal HashSet<string> Preserve;

Runtime/Legacy/Activator.cs

@@ -2,6 +2,7 @@
 using UnityEditor;
 using UnityEditor.SceneManagement;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -13,6 +14,7 @@ namespace Anatawa12.AvatarOptimizer
     [ExecuteAlways]
     [DefaultExecutionOrder(-9989)]
     [DisallowMultipleComponent]
+    [NotKeyable]
     internal class Activator : MonoBehaviour
     {
         private void OnValidate()

Runtime/Legacy/GlobalActivator.cs

@@ -1,11 +1,13 @@
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.ApplyOnPlay
 {
     [DefaultExecutionOrder(-100000)]
     [ExecuteAlways]
     [AddComponentMenu("")]
     [DisallowMultipleComponent]
+    [NotKeyable]
     internal class GlobalActivator : MonoBehaviour
     {
 #if UNITY_EDITOR

Runtime/MakeChildren.cs

@@ -1,5 +1,6 @@
 using CustomLocalization4EditorExtension;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -8,9 +9,9 @@ namespace Anatawa12.AvatarOptimizer
     [HelpURL("https://vpm.anatawa12.com/avatar-optimizer/ja/docs/reference/make-children/")]
     internal class MakeChildren : AvatarTagComponent
     {
-        [CL4EELocalized("MakeChildren:prop:executeEarly", "MakeChildren:tooltip:executeEarly")]
+        [NotKeyable, CL4EELocalized("MakeChildren:prop:executeEarly", "MakeChildren:tooltip:executeEarly")]
         public bool executeEarly;
-        [CL4EELocalized("MakeChildren:prop:children")]
+        [NotKeyable, CL4EELocalized("MakeChildren:prop:children")]
         public PrefabSafeSet.TransformSet children;
     }
 }

Runtime/MergeBone.cs

@@ -1,6 +1,7 @@
 using Anatawa12.AvatarOptimizer.ErrorReporting;
 using CustomLocalization4EditorExtension;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -9,7 +10,7 @@ namespace Anatawa12.AvatarOptimizer
     [HelpURL("https://vpm.anatawa12.com/avatar-optimizer/ja/docs/reference/merge-bone/")]
     internal class MergeBone : AvatarTagComponent, IStaticValidated
     {
-        [CL4EELocalized("MergeBone:prop:avoidNameConflict", "MergeBone:tooltip:avoidNameConflict")]
+        [NotKeyable, CL4EELocalized("MergeBone:prop:avoidNameConflict", "MergeBone:tooltip:avoidNameConflict")]
         [ToggleLeft]
         public bool avoidNameConflict;
 

Runtime/MergePhysBone.cs

@@ -4,6 +4,7 @@
 using CustomLocalization4EditorExtension;
 using JetBrains.Annotations;
 using UnityEngine;
+using UnityEngine.Animations;
 using VRC.Dynamics;
 
 namespace Anatawa12.AvatarOptimizer
@@ -14,57 +15,58 @@ namespace Anatawa12.AvatarOptimizer
     [HelpURL("https://vpm.anatawa12.com/avatar-optimizer/ja/docs/reference/merge-physbone/")]
     internal class MergePhysBone : AvatarTagComponent, IStaticValidated
     {
+        [NotKeyable]
         [CL4EELocalized("MergePhysBone:prop:makeParent", "MergePhysBone:tooltip:makeParent")]
         public bool makeParent;
 
         #region OverrideAndValue
 
-        public VersionConfig versionConfig;
+        [NotKeyable] public VersionConfig versionConfig;
 
         #region == Transform ==
         // rootTransform
         // ignoreTransforms
-        public EndPointPositionConfig endpointPositionConfig;
+        [NotKeyable] public EndPointPositionConfig endpointPositionConfig;
         // multiChildType
         #endregion
 
         #region == Forces ==
-        public IntegrationTypeConfig integrationTypeConfig;
-        public Curve0To1Config pullConfig;
+        [NotKeyable] public IntegrationTypeConfig integrationTypeConfig;
+        [NotKeyable] public Curve0To1Config pullConfig;
         // spring a.k.a. Momentum
-        public Curve0To1Config springConfig;
-        public Curve0To1Config stiffnessConfig;
-        public CurveM1To1Config gravityConfig;
-        public Curve0To1Config gravityFalloffConfig;
-        public ImmobileTypeConfig immobileTypeConfig;
-        public Curve0To1Config immobileConfig;
+        [NotKeyable] public Curve0To1Config springConfig;
+        [NotKeyable] public Curve0To1Config stiffnessConfig;
+        [NotKeyable] public CurveM1To1Config gravityConfig;
+        [NotKeyable] public Curve0To1Config gravityFalloffConfig;
+        [NotKeyable] public ImmobileTypeConfig immobileTypeConfig;
+        [NotKeyable] public Curve0To1Config immobileConfig;
         #endregion
         #region == Limits ==
-        public LimitTypeConfig limitTypeConfig;
-        public Curve0To180Config maxAngleXConfig = new Curve0To180Config(45f);
-        public Curve0To90Config maxAngleZConfig = new Curve0To90Config(45f);
-        public CurveVector3Config limitRotationConfig;
+        [NotKeyable] public LimitTypeConfig limitTypeConfig;
+        [NotKeyable] public Curve0To180Config maxAngleXConfig = new Curve0To180Config(45f);
+        [NotKeyable] public Curve0To90Config maxAngleZConfig = new Curve0To90Config(45f);
+        [NotKeyable] public CurveVector3Config limitRotationConfig;
         #endregion
         #region == Collision ==
-        public CurveNoLimitConfig radiusConfig;
-        public PermissionConfig allowCollisionConfig;
-        public CollidersConfig collidersConfig;
+        [NotKeyable] public CurveNoLimitConfig radiusConfig;
+        [NotKeyable] public PermissionConfig allowCollisionConfig;
+        [NotKeyable] public CollidersConfig collidersConfig;
         #endregion
         #region == Stretch & Squish ==
-        public Curve0To1Config stretchMotionConfig;
-        public CurveNoLimitConfig maxStretchConfig;
-        public Curve0To1Config maxSquishConfig;
+        [NotKeyable] public Curve0To1Config stretchMotionConfig;
+        [NotKeyable] public CurveNoLimitConfig maxStretchConfig;
+        [NotKeyable] public Curve0To1Config maxSquishConfig;
         #endregion
         #region == Grab & Pose ==
-        public PermissionConfig allowGrabbingConfig;
-        public PermissionConfig allowPosingConfig;
-        public Float0To1Config grabMovementConfig;
-        public BoolConfig snapToHandConfig;
+        [NotKeyable] public PermissionConfig allowGrabbingConfig;
+        [NotKeyable] public PermissionConfig allowPosingConfig;
+        [NotKeyable] public Float0To1Config grabMovementConfig;
+        [NotKeyable] public BoolConfig snapToHandConfig;
         #endregion
         #region == Options ==
-        public ParameterConfig parameterConfig;
-        public IsAnimatedConfig isAnimatedConfig;
-        public BoolConfig resetWhenDisabledConfig;
+        [NotKeyable] public ParameterConfig parameterConfig;
+        [NotKeyable] public IsAnimatedConfig isAnimatedConfig;
+        [NotKeyable] public BoolConfig resetWhenDisabledConfig;
         #endregion
 
         [Serializable]

Runtime/MergeSkinnedMesh.cs

@@ -1,6 +1,7 @@
 using Anatawa12.AvatarOptimizer.ErrorReporting;
 using CustomLocalization4EditorExtension;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -17,7 +18,7 @@ internal class MergeSkinnedMesh : EditSkinnedMeshComponent, IStaticValidated
         public PrefabSafeSet.MaterialSet doNotMergeMaterials;
 
         // common between v0 and v1
-        [CL4EELocalized("MergeSkinnedMesh:prop:removeEmptyRendererObject")]
+        [NotKeyable, CL4EELocalized("MergeSkinnedMesh:prop:removeEmptyRendererObject")]
         [ToggleLeft]
         public bool removeEmptyRendererObject = true;
 

Runtime/MergeToonLitMaterial.cs

@@ -1,5 +1,6 @@
 using System;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {

Runtime/TraceAndOptimize.cs

@@ -1,6 +1,7 @@
 using System;
 using CustomLocalization4EditorExtension;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -10,31 +11,37 @@ namespace Anatawa12.AvatarOptimizer
     [HelpURL("https://vpm.anatawa12.com/avatar-optimizer/ja/docs/reference/trace-and-optimize/")]
     internal class TraceAndOptimize : AvatarGlobalComponent
     {
+        [NotKeyable]
         [CL4EELocalized("TraceAndOptimize:prop:freezeBlendShape")]
         [ToggleLeft]
         public bool freezeBlendShape = true;
+        [NotKeyable]
         [CL4EELocalized("TraceAndOptimize:prop:removeUnusedObjects")]
         [ToggleLeft]
         public bool removeUnusedObjects = true;
 
         // Remove Unused Objects Options
+        [NotKeyable]
         [CL4EELocalized("TraceAndOptimize:prop:preserveEndBone",
             "TraceAndOptimize:tooltip:preserveEndBone")]
         [ToggleLeft]
         public bool preserveEndBone;
 
         // common parsing configuration
+        [NotKeyable]
         [CL4EELocalized("TraceAndOptimize:prop:mmdWorldCompatibility",
             "TraceAndOptimize:tooltip:mmdWorldCompatibility")]
         [ToggleLeft]
         public bool mmdWorldCompatibility = true;
 
         // for compatibility, this is not inside AdvancedSettings but this is part of Advanced Settings
+        [NotKeyable]
         [InspectorName("Use Advanced Animator Parser")]
         [Tooltip("Advanced Animator Parser will parse your AnimatorController, including layer structure.")]
         [ToggleLeft]
         public bool advancedAnimatorParser = true;
 
+        [NotKeyable]
         public AdvancedSettings advancedSettings;
 
         [Serializable]

Runtime/UnusedBonesByReferencesTool.cs

@@ -1,6 +1,7 @@
 using System;
 using CustomLocalization4EditorExtension;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer
 {
@@ -10,11 +11,13 @@ namespace Anatawa12.AvatarOptimizer
     [Obsolete("Obsoleted by Trace and Optimize")]
     internal class UnusedBonesByReferencesTool : AvatarGlobalComponent
     {
+        [NotKeyable]
         [CL4EELocalized("UnusedBonesByReferencesTool:prop:preserveEndBone", 
         "UnusedBonesByReferencesTool:tooltip:preserveEndBone")]
         [ToggleLeft]
         public bool preserveEndBone = true;
 
+        [NotKeyable]
         [CL4EELocalized("UnusedBonesByReferencesTool:prop:detectExtraChild", 
         "UnusedBonesByReferencesTool:tooltip:detectExtraChild")]
         [ToggleLeft]

Test~/ComponentSettingsTest.cs

@@ -4,7 +4,9 @@
 using System.Reflection;
 using Anatawa12.ApplyOnPlay;
 using NUnit.Framework;
+using UnityEditor;
 using UnityEngine;
+using UnityEngine.Animations;
 
 namespace Anatawa12.AvatarOptimizer.Test
 {
@@ -40,6 +42,19 @@ public void CheckDisallowMultipleComponentIsSpecified(Type type)
             Assert.That(addComponentMenu, Is.Not.Null);
         }
 
+        [Test]
+        [TestCaseSource(nameof(ComponentTypes))]
+        public void CheckNotKeyable(Type type)
+        {
+            var gameObject = new GameObject();
+            gameObject.AddComponent(type);
+            var bindings = AnimationUtility.GetAnimatableBindings(gameObject, gameObject)
+                .Where(x => x.type == type)
+                .Where(x => x.propertyName != "m_Enabled")
+                .ToArray();
+            Assert.That(bindings, Is.Empty);
+        }
+
         static IEnumerable<Type> ComponentTypes()
         {
             return