Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error if some renderer is removed #54

Merged
merged 2 commits into from
Mar 20, 2023
Merged

fix: error if some renderer is removed #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
212ed2f
fix: error if some renderer is removed
anatawa12 Mar 20, 2023
82377bd
docs(changelog): error if some component is removed
anatawa12 Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-PRERELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
### Removed

### Fixed
- NullReferenceException if some component is removed `#54`

### Security

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
### Removed

### Fixed
- NullReferenceException if some component is removed `#54`

### Security

Expand Down
2 changes: 1 addition & 1 deletion Internal/PrefabSafeSet/Runtime/PrefabSafeSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ protected PrefabSafeSet(Object outerObject)

public HashSet<T> GetAsSet()
{
var result = new HashSet<T>(mainSet);
var result = new HashSet<T>(mainSet.Where(x => x.IsNotNull()));
foreach (var layer in prefabLayers)
layer.ApplyTo(result);
return result;
Expand Down