Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors #520

Merged
merged 45 commits into from
Oct 14, 2023
Merged

Refactors #520

merged 45 commits into from
Oct 14, 2023

Conversation

anatawa12
Copy link
Owner

@anatawa12 anatawa12 commented Sep 28, 2023

For 1.5.1 1.6

Fixes #579

@anatawa12 anatawa12 added the refactor pull request that refactors label Sep 28, 2023
@anatawa12 anatawa12 changed the title More ndmf Refactors Sep 28, 2023
@anatawa12
Copy link
Owner Author

OtherMutateComponentsはレビューdone

@anatawa12
Copy link
Owner Author

ComponentDependencyCollectorはレビューdone
alloc減らす努力してみようかなと思ってる

@anatawa12 anatawa12 mentioned this pull request Oct 3, 2023
@anatawa12 anatawa12 marked this pull request as ready for review October 7, 2023 12:52
@anatawa12
Copy link
Owner Author

やりたいこと: ModificationCollectとObjectMapping周りうまいこと連携したい

@anatawa12

This comment was marked as outdated.

# Conflicts:
#	Editor/Processors/SkinnedMeshes/MergeSkinnedMeshProcessor.cs
#	Editor/Processors/TraceAndOptimize/ComponentDependencyCollector.cs
@anatawa12
Copy link
Owner Author

kaikogaさんがこれを元に作業したがってるようなので一旦mergeして続きはべつブランチにします

@anatawa12 anatawa12 enabled auto-merge October 14, 2023 14:21
@anatawa12 anatawa12 merged commit 063042c into master Oct 14, 2023
5 checks passed
@anatawa12 anatawa12 deleted the more-ndmf branch October 14, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor pull request that refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUID+fileIDベースでコンポーネントを指定する
1 participant