chore: improve performance of blendshape manipulation #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance of blendshape manipulation by keeping blendshape data in flat arrays as much as possible, and using Burst where reasonable.
|
In draft pending:
|
anatawa12
reviewed
Sep 18, 2023
| } | ||
| } | ||
|
|
||
| public void ReadStaticMesh([NotNull] Mesh mesh) | ||
| { | ||
| InitialVertexCount = mesh.vertexCount; | ||
| BlendShapeData = new BlendshapeInfo(mesh); |
There was a problem hiding this comment.
もし非SkinnedなMesh RendererのMeshにBlendShapeがあった場合にBlendShapeを読み込むのを避けるため、ReadStaticMeshではBlendShapeはパースしないでいただきたいです
anatawa12
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance of blendshape manipulation by keeping blendshape
data in flat arrays as much as possible, and using Burst where reasonable.