-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial integration with NDMF #375
Conversation
Note also that I haven't even looked at the tests yet. Mostly throwing it out for API review. For testing with MA, test using the |
4cfa199
to
6f88d1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
また、ベータとして出来そうな感じであればdraft解除していただきたいです。何かしらの形でリリースしたいなと思います
Internal/ApplyOnPlay/Editor/com.anatawa12.avatar-optimizer.internal.apply-on-play.editor.asmdef
Show resolved
Hide resolved
Internal/ApplyOnPlay/Editor/com.anatawa12.avatar-optimizer.internal.apply-on-play.editor.asmdef
Outdated
Show resolved
Hide resolved
@bdunderscore closeした意図は何でしょうか? |
なぜcloseになったかよくわからないやつ |
ドラフト解除する前に
とくに、0.3で出した場合、1.0へ移行した時はAAOへの影響を考える必要があります。 |
|
ドラフト解除する前に、非対応バージョンが入った場合忠告を出すシステムを組み込みたいと考えています(=指定バージョン以降ならNDMF対応を無効化したうえで、エラー表示システムで注意を出す) |
1.0.0をリリースすることにしたので、バージョンずれエラーをなしにしました。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ありがとうございます!
This is a draft integration with the ABPF framework, mostly to demonstrate the API. For now, this removes the old Apply On Play logic; not sure if we want to put this back for a transition period, or have it disable itself while ABPF is enabled.
(note: I expect to rename ABPF at some point, consider namespace names/etc to be temporary)