Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial integration with NDMF #375

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Conversation

bdunderscore
Copy link
Contributor

This is a draft integration with the ABPF framework, mostly to demonstrate the API. For now, this removes the old Apply On Play logic; not sure if we want to put this back for a transition period, or have it disable itself while ABPF is enabled.

(note: I expect to rename ABPF at some point, consider namespace names/etc to be temporary)

@bdunderscore
Copy link
Contributor Author

Note also that I haven't even looked at the tests yet. Mostly throwing it out for API review.

For testing with MA, test using the 000/plugin branch.

@anatawa12 anatawa12 added the enhancement New feature or request label Sep 6, 2023
@bdunderscore bdunderscore changed the title feat: Initial integration with ABPF feat: Initial integration with NDMF Sep 10, 2023
@bdunderscore bdunderscore force-pushed the abpf branch 3 times, most recently from 4cfa199 to 6f88d1d Compare September 17, 2023 20:26
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

また、ベータとして出来そうな感じであればdraft解除していただきたいです。何かしらの形でリリースしたいなと思います

Editor/OptimizerSession.cs Show resolved Hide resolved
CHANGELOG-PRERELEASE.md Outdated Show resolved Hide resolved
@anatawa12
Copy link
Owner

@bdunderscore closeした意図は何でしょうか?

@bdunderscore
Copy link
Contributor Author

なぜcloseになったかよくわからないやつ

@bdunderscore
Copy link
Contributor Author

ドラフト解除する前に

  • エラー表示の挙動が少し怪しかったので要調査
  • NDMFのバージョンを決める(0.3で出すか、1.0にするかなど)

とくに、0.3で出した場合、1.0へ移行した時はAAOへの影響を考える必要があります。

@anatawa12
Copy link
Owner

[0.3, 0.4), つまり0.3.xのみの仮対応の形にしようと思ってます。こうすると 1.0.0までの間にAPI変更あっても問題がなくなります(別途なんかAAOでエラー出すかもですがそれはまた考えます)

@bdunderscore
Copy link
Contributor Author

ドラフト解除する前に、非対応バージョンが入った場合忠告を出すシステムを組み込みたいと考えています(=指定バージョン以降ならNDMF対応を無効化したうえで、エラー表示システムで注意を出す)

@bdunderscore
Copy link
Contributor Author

1.0.0をリリースすることにしたので、バージョンずれエラーをなしにしました。
なお、1.0.1以降に対応していますが、0.4.0からはコンパイル可能になります。

@bdunderscore bdunderscore marked this pull request as ready for review September 24, 2023 08:12
Copy link
Owner

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます!

@anatawa12 anatawa12 merged commit f8c0f15 into anatawa12:master Sep 24, 2023
5 checks passed
@bdunderscore bdunderscore deleted the abpf branch September 24, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants