Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization is not applied for some fields #186

Merged
merged 3 commits into from
May 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-PRERELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The format is based on [Keep a Changelog].
- We cannot set override setting of Colliders to Copy `#183`
- Error with MergeToonLit `#185`
- Poor word choice in Japanese Translation `#174`
- Localization is not applied for some fields `#186`

### Security

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The format is based on [Keep a Changelog].
- We cannot set override setting of Colliders to Copy `#183`
- Error with MergeToonLit `#185`
- Poor word choice in Japanese Translation `#174`
- Localization is not applied for some fields `#186`

### Security

Expand Down
3 changes: 2 additions & 1 deletion Editor/RemoveMeshInBoxEditor.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using CustomLocalization4EditorExtension;
using JetBrains.Annotations;
using UnityEditor;
using UnityEngine;
Expand Down Expand Up @@ -107,7 +108,7 @@ public override void OnGUI(Rect position, SerializedProperty property, GUIConten
}

// rotation in euler
var rotationLabel = new GUIContent("Rotation");
var rotationLabel = new GUIContent(CL4EE.Tr("RemoveMeshInBox:BoundingBox:prop:rotation"));
rotationLabel = EditorGUI.BeginProperty(position, rotationLabel, rotationProp);
EditorGUI.BeginChangeCheck();
var euler = EditorGUI.Vector3Field(position, rotationLabel, eulerCache.euler);
Expand Down