Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration should check for read only package #136

Merged
merged 4 commits into from
May 6, 2023

Conversation

DerpyNewbie
Copy link
Contributor

Fixes #135
AssetDatabase#FindAssetsAssets/ フォルダのみのフィルタを掛けることで修正

@anatawa12
Copy link
Owner

Packages/がRead onlyとは限らないためAssets以下のみにするのは不十分であるため、こちらの手順を用いて判断していただきたいです。

@DerpyNewbie
Copy link
Contributor Author

read onlyかどうか確認するように修正しました。別PRにしたほうがよかったですかね...?

@DerpyNewbie DerpyNewbie changed the title fix: migration should only search Assets/ folder fix: migration should check for read only package May 6, 2023
@anatawa12
Copy link
Owner

いえいえ。大丈夫です。ChangeLog書いてmergeしますね。

@anatawa12 anatawa12 enabled auto-merge May 6, 2023 12:49
@anatawa12 anatawa12 merged commit 28f19bf into anatawa12:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene migration throws ArgumentException when read-only scene exist
2 participants