perf: improve performance of AutoMergeBlendShape #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunderscore
force-pushed
the
merge-blend-shape
branch
from
bd9d8a6 to
f3ce636
Compare
bdunderscore
commented
Nov 4, 2024
anatawa12
approved these changes
Nov 4, 2024
This pass was obtaining the blendshape buffer for each vertex, then processing those buffers. However, in practice, most vertices share the same buffer; this pass ignored this, and redid the same work thousands of times as a result. This reduces processing time from ~370ms to ~22ms on my main avatar.
bdunderscore
force-pushed
the
merge-blend-shape
branch
from
3812914 to
9b99c3c
Compare
|
LGTM. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass was obtaining the blendshape buffer for each vertex, then processing those buffers.
However, in practice, most vertices share the same buffer; this pass ignored this, and redid
the same work thousands of times as a result.
This reduces processing time from ~370ms to ~22ms on my main avatar.