perf: optimize InternalAutoFreezeMeaninglessBlendShapeProcessor #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunderscore
force-pushed
the
meaningless-perf
branch
from
796a644 to
d92c45a
Compare
This saves over 250ms on my main avatar.
bdunderscore
force-pushed
the
meaningless-perf
branch
from
d92c45a to
cf05061
Compare
anatawa12
requested changes
Nov 4, 2024
Editor/Processors/SkinnedMeshes/InternalAutoFreezeMeaninglessBlendShapeProcessor.cs
Outdated
Show resolved
Hide resolved
CHANGELOG.md
Outdated
| @@ -131,6 +131,7 @@ The format is based on [Keep a Changelog]. | |||
| - Fix non-VRChat project support `#1310` | |||
| - 'shader' doesn't have a float or range property 'prop' error `#1312` | |||
| - Error if all components are on inactive GameObject `#1318` | |||
| - Improved performance in InternalAutoFreezeMeaninglessBlendShapeProcessor `#1325` | |||
There was a problem hiding this comment.
Can you add PR number to Performance Improvements in Changed section instead of adding new entry?
…lendShapeProcessor.cs Co-authored-by: anatawa12 <[email protected]>
|
I'll ignore the commitlint failure for this PR. |
Ah, I thought you would squash it on merge. I’ll check that in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves over 250ms on my main avatar.