-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically Merge Blendshape #1300
Conversation
@@ -33,7 +33,7 @@ For example, `AAO Merge Skinned Mesh` component in 1.7.x or older merges BlendSh | |||
This behavior is treated as a bug since this makes impossible to animate them separately.\ | |||
You may use this bug to sync the BlendShape animation of an Skinned Mesh Renderer with one of another Skinned Mesh Renderer.\ | |||
However, this is not supported behavior and some other components may break the behavior.\ | |||
For example, `Automatically Freeze BlendShape` in `AAO Trace and Optimize` component will freezes the BlendShapes which might be animated with this buggy behavior by being merged by `AAO Merge Skinned Mesh` component. | |||
For example, `Optimize BlendShape` in `AAO Trace and Optimize` component will freezes the BlendShapes which might be animated with this buggy behavior by being merged by `AAO Merge Skinned Mesh` component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
この辺りの記述古くなったりしている?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. なので放置した。 #1297
Co-authored-by: Sayamame-beans <[email protected]>
Co-authored-by: anatawa12 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
良さそう(多分)
In #1286, We introduced
RenameToAvoidConflict
mode for Merge Skinned Mesh but it will increase BlendShape count, this is not good for optimization.This PR introduces Automatically Merge BlendShape for Trace and Optimize to relax this problem.
Automatically Merge BlendShape is added as a part of Optimize BlendShape feature, which was Automatically Freeze BlendShape in 1.7.x or earlier.