Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Merge Blendshape #1300

Merged
merged 9 commits into from
Oct 30, 2024
Merged

Automatically Merge Blendshape #1300

merged 9 commits into from
Oct 30, 2024

Conversation

anatawa12
Copy link
Owner

In #1286, We introduced RenameToAvoidConflict mode for Merge Skinned Mesh but it will increase BlendShape count, this is not good for optimization.

This PR introduces Automatically Merge BlendShape for Trace and Optimize to relax this problem.

Automatically Merge BlendShape is added as a part of Optimize BlendShape feature, which was Automatically Freeze BlendShape in 1.7.x or earlier.

@anatawa12 anatawa12 marked this pull request as ready for review October 25, 2024 15:40
@@ -33,7 +33,7 @@ For example, `AAO Merge Skinned Mesh` component in 1.7.x or older merges BlendSh
This behavior is treated as a bug since this makes impossible to animate them separately.\
You may use this bug to sync the BlendShape animation of an Skinned Mesh Renderer with one of another Skinned Mesh Renderer.\
However, this is not supported behavior and some other components may break the behavior.\
For example, `Automatically Freeze BlendShape` in `AAO Trace and Optimize` component will freezes the BlendShapes which might be animated with this buggy behavior by being merged by `AAO Merge Skinned Mesh` component.
For example, `Optimize BlendShape` in `AAO Trace and Optimize` component will freezes the BlendShapes which might be animated with this buggy behavior by being merged by `AAO Merge Skinned Mesh` component.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この辺りの記述古くなったりしている?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. なので放置した。 #1297

Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう(多分)

@anatawa12 anatawa12 merged commit f55fc81 into master Oct 30, 2024
6 checks passed
@anatawa12 anatawa12 deleted the auto-merge-blendshape branch October 30, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants