Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improvements on editor public api #1143

Merged
merged 12 commits into from
Aug 26, 2024
Merged

docs: improvements on editor public api #1143

merged 12 commits into from
Aug 26, 2024

Conversation

anatawa12
Copy link
Owner

No description provided.

@anatawa12 anatawa12 force-pushed the api-xml-doc-improvements branch from 2dd064d to f8bbe51 Compare August 19, 2024 16:24
@anatawa12 anatawa12 marked this pull request as ready for review August 19, 2024 16:29
@anatawa12 anatawa12 changed the base branch from master to master-1.7 August 20, 2024 06:57
Sayamame-beans
Sayamame-beans requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

途中ですが一旦投げます

.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
Sayamame-beans
Sayamame-beans requested changes Aug 23, 2024
View reviewed changes
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
Sayamame-beans
Sayamame-beans requested changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語はまだ確認してないですが

.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.ja.md Outdated Show resolved Hide resolved
Sayamame-beans
Sayamame-beans requested changes Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語(without xmldoc)

.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
.docs/content/docs/developers/make-your-components-compatible-with-aao/index.md Outdated Show resolved Hide resolved
Sayamame-beans
Sayamame-beans approved these changes Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

その他は特に気になるところはないです
見落としはあるかもしれませんが…

あとxmldocは殆ど読んでないです(主語がAvatar Optimizerの文が短い間に多いなぁとはなりました)

@anatawa12
Copy link
Owner Author

xmldocだとAvatar Optimizerなのかyour toolなのかが結構だいじがちなので明確さを優先したのはある...

@anatawa12 anatawa12 enabled auto-merge August 26, 2024 13:08
@anatawa12 anatawa12 merged commit f9a2dfd into master-1.7 Aug 26, 2024
8 checks passed
@anatawa12 anatawa12 deleted the api-xml-doc-improvements branch August 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sayamame-beans Sayamame-beans Sayamame-beans approved these changes

Assignees
No one assigned
Labels
NO-CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anatawa12 @Sayamame-beans