fix(T&O): VRMのFirstPersonFlagをCategorizationKeyに追加する #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ned Meshes with different FirstPerson settings
anatawa12
reviewed
Jun 23, 2024
| } | ||
| #endif | ||
| // note: unset will fallback to Auto | ||
| return VrmFirstPersonFlag.Auto; |
There was a problem hiding this comment.
このままだと手動MergeSkinMedMeshのあとのやつがすべてAutoに化けたりしちゃぃませんかね
少し対処法考えさせてください
There was a problem hiding this comment.
ObjectMappingの方でFirstPerson性を持たせせてあげる必要がありそうかなぁ
There was a problem hiding this comment.
AvatarOptimizer/Editor/APIInternal/ComponentInfos.VRM0.cs
Lines 122 to 129 in e70328f
みたいなことをObjectMappingBuilderを少しいじって取得できるようにしてもいいかも
|
すみません、しばらくかかりそうです！
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1071
（この調子で無限に足し続けるってことにはならないと信じたいです）