Merge pull request #615 from anatawa12/read-write-mesh-off-support

chore: remove mesh not readable error Since we create Mesh instead if instantiate, R/W mesh is no longer required.
anatawa12 · Oct 17, 2023 · f4c19ea · f4c19ea
2 parents f288ab5 + 67e06ca
commit f4c19ea
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/CHANGELOG-PRERELEASE.md b/CHANGELOG-PRERELEASE.md
@@ -14,6 +14,8 @@ The format is based on [Keep a Changelog].
 ### Deprecated
 
 ### Removed
+- Error for Read/Write Mesh off Mesh `#615`
+  - Since AAO creates Mesh every time, no more error is required!
 
 ### Fixed
 - BindPose Optimization may break mesh with scale 0 bone `#612`

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,8 @@ The format is based on [Keep a Changelog].
 ### Deprecated
 
 ### Removed
+- Error for Read/Write Mesh off Mesh `#615`
+  - Since AAO creates Mesh every time, no more error is required!
 
 ### Fixed
 - Multi-frame BlendShape can be broken `#601`

diff --git a/Editor/Processors/SkinnedMeshes/MeshInfo2.cs b/Editor/Processors/SkinnedMeshes/MeshInfo2.cs
@@ -37,11 +37,6 @@ public MeshInfo2(SkinnedMeshRenderer renderer)
         {
             SourceRenderer = renderer;
             var mesh = renderer.sharedMesh;
-            if (mesh && !mesh.isReadable)
-            {
-                BuildReport.LogFatal("The Mesh is not readable. Please Check Read/Write")?.WithContext(mesh);
-                return;
-            }
 
             BuildReport.ReportingObject(renderer, true, () =>
             {
@@ -79,11 +74,6 @@ public MeshInfo2(MeshRenderer renderer)
             {
                 var meshFilter = renderer.GetComponent<MeshFilter>();
                 var mesh = meshFilter ? meshFilter.sharedMesh : null;
-                if (mesh && !mesh.isReadable)
-                {
-                    BuildReport.LogFatal("The Mesh is not readable. Please Check Read/Write")?.WithContext(mesh);
-                    return;
-                }
                 if (mesh)
                     ReadStaticMesh(mesh);