Merge pull request #857 from anatawa12/fix-constraint-broken-with-aut…

…o-activeness

fix: nested constraint may be broken

CHANGELOG-PRERELEASE.md

@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
 ### Removed
 
 ### Fixed
+- Nested Constraint can be broken with Trace and Optimize `#857`
 
 ### Security
 

CHANGELOG.md

@@ -27,6 +27,7 @@ The format is based on [Keep a Changelog].
 - Added workaround for `Array index (n) is out of bounds (size=m)` error
 - Humanoid Bones may be removed by Trace and Optimize `#831`
 - Add `license`, `documentationUrl`, and `changelogUrl` to package.json `#851`
+- Nested Constraint can be broken with Trace and Optimize `#857`
 
 ### Security
 

Editor/APIInternal/ComponentInfos.cs

@@ -330,7 +330,15 @@ protected override void CollectDependency(T component, ComponentDependencyCollec
                 .EvenIfDependantDisabled();
             for (var i = 0; i < component.sourceCount; i++)
                 collector.AddDependency(component.GetSource(i).sourceTransform);
-            collector.MarkHeavyBehaviour();
+            var isNestedConstraint =
+                component.GetComponentsInChildren<IConstraint>() != null &&
+                component.GetComponentsInParent<IConstraint>() != null;
+            // for nested constraint, our optimizer may breaks the constraint
+            // https://github.com/anatawa12/AvatarOptimizer/issues/856
+            if (isNestedConstraint)
+                collector.MarkBehaviour();
+            else
+                collector.MarkHeavyBehaviour();
         }
     }