Merge pull request #996 from anatawa12/rollback-constraint-activeness…

…-optimization

fix: rollback constraint activeness optimization

CHANGELOG-PRERELEASE.md

@@ -14,6 +14,8 @@ The format is based on [Keep a Changelog].
 ### Deprecated
 
 ### Removed
+- Activeness Optimization for Constraint component `#996`
+  - The constraint component is too complex to optimize correctly and reliably
 
 ### Fixed
 

CHANGELOG.md

@@ -14,6 +14,8 @@ The format is based on [Keep a Changelog].
 ### Deprecated
 
 ### Removed
+- Activeness Optimization for Constraint component `#996`
+  - The constraint component is too complex to optimize correctly and reliably
 
 ### Fixed
 

Editor/APIInternal/ComponentInfos.cs

@@ -330,15 +330,17 @@ protected override void CollectDependency(T component, ComponentDependencyCollec
                 .EvenIfDependantDisabled();
             for (var i = 0; i < component.sourceCount; i++)
                 collector.AddDependency(component.GetSource(i).sourceTransform);
-            var isNestedConstraint =
-                component.GetComponentsInChildren<IConstraint>() != null &&
-                component.GetComponentsInParent<IConstraint>() != null;
+            //var isNestedConstraint =
+            //    component.GetComponentsInChildren<IConstraint>() != null &&
+            //    component.GetComponentsInParent<IConstraint>() != null;
             // for nested constraint, our optimizer may breaks the constraint
             // https://github.com/anatawa12/AvatarOptimizer/issues/856
-            if (isNestedConstraint)
-                collector.MarkBehaviour();
-            else
-                collector.MarkHeavyBehaviour();
+            //if (isNestedConstraint)
+            //    collector.MarkBehaviour();
+            //else
+            //    collector.MarkHeavyBehaviour();
+            // It's too buggy. the Constraint is too complex.
+            collector.MarkBehaviour();
         }
     }