Merge pull request #683 from anatawa12/joint-disappear

fix: Joint can be disappeared unexpectedly
anatawa12 · Nov 4, 2023 · 39563ab · 39563ab
2 parents 99d0a4f + c0e7c01
commit 39563ab
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG-PRERELEASE.md b/CHANGELOG-PRERELEASE.md
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
 ### Removed
 
 ### Fixed
+- RigidBody Joint can be broken `#683`
 
 ### Security
 

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@ The format is based on [Keep a Changelog].
 ### Removed
 
 ### Fixed
+- RigidBody Joint can be broken `#683`
 
 ### Security
 

diff --git a/Editor/Processors/TraceAndOptimize/ComponentDependencyCollector.cs b/Editor/Processors/TraceAndOptimize/ComponentDependencyCollector.cs
@@ -406,8 +406,17 @@ private static void InitByTypeParsers()
             AddParserWithExtends<Collider, WheelCollider>();
             AddParser<Joint>((collector, deps, component) =>
             {
-                collector.GetDependencies(component.GetComponent<Rigidbody>()).AddActiveDependency(component);
-                deps.AddActiveDependency(component.connectedBody);
+                var rigidBody = component.GetComponent<Rigidbody>();
+                if (rigidBody)
+                {
+                    collector.GetDependencies(rigidBody).AddActiveDependency(component);
+                    deps.AddActiveDependency(rigidBody);
+                }
+                if (component.connectedBody)
+                {
+                    collector.GetDependencies(component.connectedBody).AddActiveDependency(component);
+                    deps.AddActiveDependency(component.connectedBody);
+                }
             });
             AddParserWithExtends<Joint, CharacterJoint>();
             AddParserWithExtends<Joint, ConfigurableJoint>();