[Data Explorer][Discover 2.0] Change to inspect icon and update hint msg

Issue Resolve opensearch-project#4826 opensearch-project#4825 Signed-off-by: ananzh <[email protected]>
ananzh · Aug 25, 2023 · ef72e0b · ef72e0b
1 parent 551e432
commit ef72e0b
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 38 deletions.
diff --git a/src/plugins/discover/public/application/components/data_grid/data_grid_table.tsx b/src/plugins/discover/public/application/components/data_grid/data_grid_table.tsx
@@ -8,7 +8,7 @@ import { EuiDataGrid, EuiDataGridSorting, EuiPanel } from '@elastic/eui';
 import { IndexPattern } from '../../../opensearch_dashboards_services';
 import { fetchTableDataCell } from './data_grid_table_cell_value';
 import { buildDataGridColumns, computeVisibleColumns } from './data_grid_table_columns';
-import { DocViewExpandButton } from './data_grid_table_docview_expand_button';
+import { DocViewInspectButton } from './data_grid_table_docview_inspect_button';
 import { DataGridFlyout } from './data_grid_table_flyout';
 import { DiscoverGridContextProvider } from './data_grid_table_context';
 import { toolbarVisibility } from './constants';
@@ -45,7 +45,7 @@ export const DataGridTable = ({
   displayTimeColumn,
   isToolbarVisible = true,
 }: DataGridTableProps) => {
-  const [expandedHit, setExpandedHit] = useState<OpenSearchSearchHit | undefined>();
+  const [inspectedHit, setInspectedHit] = useState<OpenSearchSearchHit | undefined>();
   const rowCount = useMemo(() => (rows ? rows.length : 0), [rows]);
   const pagination = usePagination(rowCount);
 
@@ -94,9 +94,9 @@ export const DataGridTable = ({
   const leadingControlColumns = useMemo(() => {
     return [
       {
-        id: 'expandCollapseColumn',
+        id: 'inspectCollapseColumn',
         headerCellRender: () => null,
-        rowCellRender: DocViewExpandButton,
+        rowCellRender: DocViewInspectButton,
         width: 40,
       },
     ];
@@ -134,9 +134,9 @@ export const DataGridTable = ({
   return (
     <DiscoverGridContextProvider
       value={{
-        expandedHit,
+        inspectedHit,
         onFilter,
-        setExpandedHit,
+        setInspectedHit,
         rows: rows || [],
         indexPattern,
       }}
@@ -147,15 +147,15 @@ export const DataGridTable = ({
             {table}
           </EuiPanel>
         </EuiPanel>
-        {expandedHit && (
+        {inspectedHit && (
           <DataGridFlyout
             indexPattern={indexPattern}
-            hit={expandedHit}
+            hit={inspectedHit}
             columns={columns}
             onRemoveColumn={onRemoveColumn}
             onAddColumn={onAddColumn}
             onFilter={onFilter}
-            onClose={() => setExpandedHit(undefined)}
+            onClose={() => setInspectedHit(undefined)}
           />
         )}
       </>

diff --git a/src/plugins/discover/public/application/components/data_grid/data_grid_table_context.tsx b/src/plugins/discover/public/application/components/data_grid/data_grid_table_context.tsx
@@ -8,9 +8,9 @@ import { IndexPattern } from '../../../opensearch_dashboards_services';
 import { DocViewFilterFn, OpenSearchSearchHit } from '../../doc_views/doc_views_types';
 
 export interface DataGridContextProps {
-  expandedHit?: OpenSearchSearchHit;
+  inspectedHit?: OpenSearchSearchHit;
   onFilter: DocViewFilterFn;
-  setExpandedHit: (hit?: OpenSearchSearchHit) => void;
+  setInspectedHit: (hit?: OpenSearchSearchHit) => void;
   rows: OpenSearchSearchHit[];
   indexPattern: IndexPattern;
 }

diff --git a/...iscover/public/application/components/data_grid/data_grid_table_docview_expand_button.tsx b/...iscover/public/application/components/data_grid/data_grid_table_docview_expand_button.tsx
diff --git a/...scover/public/application/components/data_grid/data_grid_table_docview_inspect_button.tsx b/...scover/public/application/components/data_grid/data_grid_table_docview_inspect_button.tsx
@@ -0,0 +1,28 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import React from 'react';
+import { i18n } from '@osd/i18n';
+import { EuiToolTip, EuiButtonIcon, EuiDataGridCellValueElementProps } from '@elastic/eui';
+import { useDataGridContext } from './data_grid_table_context';
+
+export const DocViewInspectButton = ({ rowIndex }: EuiDataGridCellValueElementProps) => {
+  const { inspectedHit, setInspectedHit, rows } = useDataGridContext();
+  const currentInspected = rows[rowIndex];
+  const isCurrentInspected = currentInspected === inspectedHit;
+  const inspectHintMsg = i18n.translate('discover.docViews.table.inspectAriaLabel', {
+    defaultMessage: 'Inspect document details',
+  });
+
+  return (
+    <EuiToolTip content={inspectHintMsg}>
+      <EuiButtonIcon
+        onClick={() => setInspectedHit(isCurrentInspected ? undefined : currentInspected)}
+        iconType={isCurrentInspected ? 'minimize' : 'inspect'}
+        aria-label={inspectHintMsg}
+      />
+    </EuiToolTip>
+  );
+};