Update test for failing build #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is blocking the yargs update release
pkuczynski
approved these changes
Oct 23, 2020
|
The build still fails. Can you have a look? |
If I fix node:stable, then node:6 fails. If I fix node:6 then stable fails. Seems like sorting order has changed since node 11: nodejs/node#24294 Since node stable was setup in Travis, the builds were failing: Before node stable(12 now): |
|
Fixed the issue accordingly, please review file to see if solution could bring potential side effects? |
|
@pkuczynski can we release it now? |
|
Thanks for all the work you put into this! Merging and releasing now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking the yargs update release