You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
Other... Please describe:
Which package are you modifying?
vite-plugin-angular
vite-plugin-nitro
astro-angular
create-analog
router
platform
content
nx-plugin
trpc
What is the current behavior?
In the current implementation, the app defaults to running trpc on http://127.0.0.1:4200/. To enhance flexibility and accommodate different hosting providers, this pull request introduces a getBaseUrl function. With this update, the trpc endpoint can be easily adjusted based on the hosting environment. Changing the port or any other configurations will now be automatically resolved, providing a more adaptable and seamless experience.
This change aims to improve the app's configurability and ensure smoother deployments across various hosting setups. Your review and feedback on this pull request would be highly appreciated. Thank you!
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Yes
No
Other information
[optional] What gif best describes this PR or how it makes you feel?
cskiwi
changed the title
feat: using base url depending on the provider
feat(nx-plugin): using base url depending on the provider
Jul 26, 2023
cskiwi
changed the title
feat(nx-plugin): using base url depending on the provider
feat(nx-plugin): TRPC using base url depending on the provider
Jul 26, 2023
I really like this!
In an ideal world the user does not have to worry about setting an absolute path at all and can simply put "/api/trpc", "trpc", etc.
Maybe this should be exposed as a function of the trpc package instead of the Nx plugin template? @brandonroberts@cskiwi what do you guys think?
I really like this! In an ideal world the user does not have to worry about setting an absolute path at all and can simply put "/api/trpc", "trpc", etc.
Maybe this should be exposed as a function of the trpc package instead of the Nx plugin template? @brandonroberts@cskiwi what do you guys think?
@goetzrobin That sounds like a good idea. However, before implementing it into the 'trpc' package, we should take a look at resolving the following issue: #468.
This precautionary step is necessary to ensure that we don't introduce any breaking changes, especially if addressing the issue requires making additional changes to the way the API is passed along. By doing this, we can assist the users while still retaining the flexibility to make changes to the 'trpc' package in the future.
Hey there @cskiwi! Check out this PR: #639
There might still be some gotchas I am missing, but it seems like it would make a getBaseUrl unnecessary and the TrpcClient would "just" work!
Hey there @cskiwi! Check out this PR: #639 There might still be some gotchas I am missing, but it seems like it would make a getBaseUrl unnecessary and the TrpcClient would "just" work!
Oh nice! this would be beautifull for the developer experience!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cskiwi
changed the title
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
In the current implementation, the app defaults to running trpc on http://127.0.0.1:4200/. To enhance flexibility and accommodate different hosting providers, this pull request introduces a getBaseUrl function. With this update, the trpc endpoint can be easily adjusted based on the hosting environment. Changing the port or any other configurations will now be automatically resolved, providing a more adaptable and seamless experience.
This change aims to improve the app's configurability and ensure smoother deployments across various hosting setups. Your review and feedback on this pull request would be highly appreciated. Thank you!
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?