fix(trpc): avoid hard coding of host/port by using $fetch/fetch when … #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available currently you need to know the host and port of the application in order to hard code the trpc endpoint. this is an issue if you want to pre-render a route calling a trpc endpoint, because during pre-rendering the application does not run on the same host/port as in dev. To address this issue we can simply use the $fetch provided by nitro when its available and fall back to the default fetch when it is not. This has a couple benefits: 1. you do no longer have to know the host/port, but can simply use /api/trpc, etc. as your endpoint 2. pre-rendering now works as expected as we query the correct nitro server Closes #468
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
22 tasks
brandonroberts
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…available
currently you need to know the host and port of the application in order to hard code the trpc endpoint. this is an issue if you want to pre-render a route calling a trpc endpoint, because during pre-rendering the application does not run on the same host/port as in dev.
To address this issue we can simply use the $fetch provided by nitro when its available and fall back to the default fetch when it is not. This has a couple benefits:
Closes #468
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
currently you need to know the host and port of the application in order to hard code the trpc endpoint. this is an issue if you want to pre-render a route calling a trpc endpoint, because during pre-rendering the application does not run on the same host/port as in dev.
Closes #468
What is the new behavior?
To address this issue we can simply use the $fetch provided by nitro when its available and fall back to the default fetch when it is not. This has a couple benefits:
Does this PR introduce a breaking change?
Other information
[optional] What gif best describes this PR or how it makes you feel?