Staging/adf4030 support #2651
Staging/adf4030 support #2651
Conversation
mhennerich
requested review from
nunojsa,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
mhennerich
force-pushed
the
staging/adf4030-support
branch
5 times, most recently
from
0d2c2cd to
dbed104
Compare
|
|
||
| adi,extended-name: | ||
| description: Extended name for the channel. | ||
| $ref: /schemas/types.yaml#/definitions/string |
There was a problem hiding this comment.
This one is questionable..
There was a problem hiding this comment.
Well it's handy, and avoids possible mix up.
| properties: | ||
| reg: | ||
| description: Channel number. | ||
| $ref: /schemas/types.yaml#/definitions/uint32 |
There was a problem hiding this comment.
This needs some constrains. I guess some of the other properties also need it.
|
|
||
| adi,rcm: | ||
| description: RCM value for the channel. | ||
| $ref: /schemas/types.yaml#/definitions/uint32 |
There was a problem hiding this comment.
A lot of these properties need a better description. Right now, the description is more or less the same what one can infer from the name.
There was a problem hiding this comment.
You will always need the datasheet to properly set those and the naming follows the datasheet.
But I agree some more text doesn't harm. Will fix.
| description: Number of iterations for auto alignment. | ||
|
|
||
| adi,bsync-autoalign-threshold-fs: | ||
| description: Threshold for auto alignment in femtoseconds. |
There was a problem hiding this comment.
I dunno the three above properties pass the binding check. They have no standard suffix and we're not defining a type for them.
Not sure why it does not fail in the check
| .shared = true, | ||
| .private = BSYNC_ALIGN_ITER, | ||
| }, | ||
| {}, |
There was a problem hiding this comment.
The above four (at least) need an ABI doc. But I guess we can do it when upstreaming...
There was a problem hiding this comment.
ABI documentation sysfs-bus-iio-frequency-adf4030
Yeah - the wiki page already has a link for it ...
https://wiki.analog.com/resources/tools-software/linux-drivers/iio-synchronizer/adf4030
mhennerich
force-pushed
the
staging/adf4030-support
branch
from
dbed104 to
6e2a7c7
Compare
Initial support... Signed-off-by: Nuno Sa <[email protected]>
Add dt-bindings for the Analog Devices ADF4030 Precision Synchronizer IC. Signed-off-by: Michael Hennerich <[email protected]>
Automatically imply ADF4030. Signed-off-by: Nuno Sa <[email protected]>
mhennerich
force-pushed
the
staging/adf4030-support
branch
from
6e2a7c7 to
ea7284a
Compare
PR Description
New Linux IIO driver for Analog Devices ADF4030 10-Channel Precision Synchronizer IC.
The ADF4030 provides for 10 bidirectional synchronized clock (BSYNC) channels and
accepts a reference clock input (REFIN) signal as a frequency reference for
generating an output clock on any BSYNC channels that are configured as an output.
The hallmark feature of the ADF4030 is the ability to time align the clock edges
of any one or more BSYNC channels to <5 ps (at the device pins) with respect to
the BSYNC channel selected as the reference BSYNC channel.
https://www.analog.com/en/products/adf4030.html
PR Type
PR Checklist