Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uninstall target #961

Merged
merged 1 commit into from
May 11, 2023

Conversation

rgetz
Copy link
Contributor

@rgetz rgetz commented May 6, 2023

Per the request #694, this adds an "uninstall" target, which is (a) good form, and (b) requested by Jeff Long, and will make PyBOMBs work more natively.

@rgetz rgetz mentioned this pull request May 6, 2023
@willcode
Copy link

willcode commented May 6, 2023

Thanks!

@pcercuei
Copy link
Contributor

pcercuei commented May 8, 2023

The license of the code you referenced in the gist is uncertain...

The code would also need to respect the DESTDIR environment variable.

@willcode
Copy link

willcode commented May 8, 2023

@rgetz
Copy link
Contributor Author

rgetz commented May 8, 2023

I will refactor based on this one: which should be better:
https://gitlab.kitware.com/cmake/community/-/wikis/FAQ#can-i-do-make-uninstall-with-cmake

the license for that is explicit -

CMake is distributed under the OSI-approved BSD 3-clause License.
See the licensing page for details.
The snippets on this wiki are provided under the same license.

Per the request analogdevicesinc#694, this adds an "uninstall" target, which is (a) good
form, and (b) requested by Jeff Long, and will make PyBOMBs work more
natively.

Signed-off-by: Robin Getz <[email protected]>
@rgetz rgetz force-pushed the rgetz-add-uninstall-target branch from 7337466 to 2e1f67e Compare May 11, 2023 11:31
@rgetz
Copy link
Contributor Author

rgetz commented May 11, 2023

updated

@pcercuei pcercuei self-requested a review May 11, 2023 13:18
@pcercuei pcercuei merged commit 0a5eaa2 into analogdevicesinc:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants