cmake: Avoid path construction in pkg-config file #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative fix for: analogdevicesinc#563 It is not generally true that `CMAKE_INSTALL_<dir>` variables are relative paths: https://github.com/jtojnar/cmake-snips#concatenating-paths-when-building-pkg-config-files Absolute paths will cause things like this to appear: includedir=${prefix}//nix/store/87zhscw1p08nqm73ls2sd82zmr1a8rni-libiio-0.21-dev/include It would be best if the paths were relative to `${prefix}` pkg-config variable so that they could be overridden: https://www.bassi.io/articles/2018/03/15/pkg-config-and-paths/ but since that is not easy to do in CMake, we will just use absolute paths. libiio does not expect other project to install artefacts to its installation paths so non-overriddable paths should no do much harm. Signed-off-by: Jan Tojnar <[email protected]>
commodo
approved these changes
Jul 7, 2020
|
i prefer this for now; thanks again :) |
|
Thanks for the review, and patch. I will merge this one, and close the other... -Robin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative fix for: #563
It is not generally true that
CMAKE_INSTALL_<dir>variables are relative paths. Absolute paths will cause things like this to appear:It would be best if the paths were relative to
${prefix}pkg-config variable so that they could be overridden but since that is not easy to do in CMake, we will just use absolute paths.libiio does not expect other project to install artefacts to its installation paths so non-overriddable paths should no do much harm.