python: code quality improvements #481
Conversation
|
Looks like a good start. Thanks.
Can you have a look at: seems to be an issue in both readdev.py and writedev.py |
cristi-iacob
force-pushed
the
python-code-improvements
branch
from
6643615 to
e430716
Compare
|
I have solved the import signal issue. |
|
One last issue... According to PEP8, if any return statement returns an expression, any return statements where no value is returned should explicitly state this as return None, and an explicit return statement should be present at the end of the function (if reachable) This is flagged in iio_info.py in the _handle_context(): function. |
cristi-iacob
force-pushed
the
python-code-improvements
branch
6 times, most recently
from
5fca118 to
d2f3b7b
Compare
|
I think you messed up the rebase - it includes some things that are already on master. |
|
If you can focus on the examples - I already have a branch for the actual iio.py fixes. (at least from a linter perspective). I will see if I can finish what I'm working on, and get back to that tomorrow. |
|
Need to ignore W0212. Otherwise the bindings would probably have to be rearchitected |
cristi-iacob
force-pushed
the
python-code-improvements
branch
from
d2f3b7b to
767a8b8
Compare
|
I removed the commit with the modifications from iio.py and rebased the branch with the current master. |
Made some modifications in order to improve the code quality, as suggested by Codacy. Signed-off-by: Cristi Iacob <[email protected]>
Added some modifications for improving the code quality for the iio_writedev.py module, accordingly to Codacy. Signed-off-by: Cristi Iacob <[email protected]>
Added some modifications for improving the code quality for the iio_info.py module, accordingly to Codacy. Signed-off-by: Cristi Iacob <[email protected]>
|
RemarkLint has two issues:
|
|
Is there any more work needed to be done here? @cristi-iacob |
|
@dNechita no, it's all done. |
|
The issues from RemarkLink are resolved in #483. |
|
@tfcollins is this ok to merge? |
|
In discussion with @cristi-iacob ; he indicated that the python examples are being re-written in a more pythonic way; and this was close to being finished. (within a week or less). It doesn't make sense to churn this with these fixes, and then replace things completely in a few days. |
If this PR isn't required, @cristi-iacob please close it. |
Code quality improvements, accordingly to Codacy.