libini added as a submodule and compiled/linked directly into libiio. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Kenda <[email protected]>
matejk
force-pushed
the
libini-submodule
branch
from
38aa5d2 to
c5cdbed
Compare
|
Let's wait for @pcercuei comments here... The options are:
-Michael |
|
This PR was not intended to fix libini CMake build but to simplify build of libiio. |
|
What's the issue with upstream libini? I have no problem if libini is added as a submodule, it would probably be a good idea since it's not packaged anywhere. |
|
Issue with upstream libini is discussed at #403 It's not a big deal - it's just a matter if you wanted to maintain this in your personal repo forever (as long as people are using libiio), or if it should be moved somewhere else? -Robin |
Merged
|
I opened #428 - I think it's the way to go. |
|
I will close this, unmerged, as it looks like #428 will be merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Kenda [email protected]
Done in a similar way as it is done for wingetopt.
Related to #403.