Fixes #303 and #302

[dimasad]

Fixes to the dummy-iiostream example.

[rgetz]

Couple comments

• we always use signed-off-by on commits (this will need to be added). to the first commit.

• int64_t is guaranteed by the C99 standard to be exactly 64 bits wide, long long normally is, but not always - and can cause problems in some places in this codebase. As long as your compiler supports C99, I don't know why this is necessary. To be truly portable - we should be using the Format macro constants, so it would look like:

uint64_t t;
printf("%" PRIu64 "\n", t);

-Robin

[dimasad]

I used long long because it is guaranteed to be at least 64 bits wide, which is enough to prevent overflow. I was using gcc on the BeagleBone Black, and the specifier "%ld" with int64_t did not work. In that architecture, a long is 32 bits and overflow occurs.

Anyways, format macros can lead to a more elegant solution. I'll change that and add the sign-off.

[mhennerich]

Can you please add your signed-of-by tag to the commit message and then push again?
Without we can't merge this PR.

[dimasad]

Sorry, I totally forgot about this. Will have time to do this Friday 2019-11-29.

[dimasad]

To be truly portable - we should be using the Format macro constants, so it would look like:

uint64_t t;
printf("%" PRIu64 "\n", t);

@rgetz, I updated to your truly portable solution.

[pcercuei]

Just a nitpick - you use PRI "i" 16 and PRI "d" 64, both variants are fine, but you could use the same one to be consistent :)

[dimasad]

Just a nitpick - you use PRI "i" 16 and PRI "d" 64, both variants are fine, but you could use the same one to be consistent :)

Well, I also am very OCD about these things. Anyways, the previous coder of the example used both %i and %d. So what I did was replace all %d with PRIdXX and %i with PRIiXX. Do you still want me to change it or is my choice reasonable enough?

[pcercuei]

Up to you.

[dimasad]

I would rather just leave it like it is then.

…

On Mon, 2 Dec 2019 at 16:14, Paul Cercueil ***@***.***> wrote: Up to you. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#304?email_source=notifications&email_token=AAHRO5JXMMH2Z4IA7ZPY4ITQWVGCBA5CNFSM4INHNLPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFUMPZI#issuecomment-560515045>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO5KPING46BCJJCA6HPDQWVGCBANCNFSM4INHNLPA> .