Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: remove OS X El Capitan (10.11) from readme #295

Merged
merged 2 commits into from
Jul 26, 2019
Merged

README.md: remove OS X El Capitan (10.11) from readme #295

merged 2 commits into from
Jul 26, 2019

Conversation

commodo
Copy link
Contributor

@commodo commodo commented Jul 24, 2019

Given that suport for Xcode 11 is being added, maybe it's a good idea to
drop support for Xcode 9.

The readme file also contained a left-over for Xcode8 (OS X 10.10) which
was removed a while back. This was removed with this change.

Signed-off-by: Alexandru Ardelean [email protected]

@commodo commodo requested review from tfcollins, rgetz and a team July 24, 2019 08:05
@commodo
Copy link
Contributor Author

commodo commented Jul 24, 2019

for the PR, I'll add a RFC tag;
mostly to highlight that this is a proposal in the form of a PR;

@commodo commodo changed the title build,.travis.yml: drop support for Xcode 9 [RFC] build,.travis.yml: drop support for Xcode 9 Jul 24, 2019
@rgetz
Copy link
Contributor

rgetz commented Jul 24, 2019

macOS 10.12 (xcode 9) is still supported by MathWorks - who uses libiio; so we need to continue to support things.

https://www.mathworks.com/support/requirements/matlab-system-requirements.html
macOS Mojave (10.14)
macOS High Sierra (10.13)
macOS Sierra (10.12)

When they drop it - we can drop it.

@commodo
Copy link
Contributor Author

commodo commented Jul 25, 2019

When they drop it - we can drop it.

ack;
then i'll go for plan B; cleanup the README.md [remove macOS Sierra (10.12)] ; since it was forgotten there

@commodo
Copy link
Contributor Author

commodo commented Jul 25, 2019

When they drop it - we can drop it.

ack;
then i'll go for plan B; cleanup the README.md [remove macOS Sierra (10.12)] ; since it was forgotten there

i wrote the above stuff before coffee;
i'll remove OS X El Capitan (v 10.11) from the README list

@commodo
README.md: remove OS X El Capitan (10.11) from readme
826e7d7 
The builds were removed when support for Xcode 8 was removed.
This change removes it from the README.

Signed-off-by: Alexandru Ardelean <[email protected]>
@commodo commodo changed the title [RFC] build,.travis.yml: drop support for Xcode 9 README.md: remove OS X El Capitan (10.11) from readme Jul 25, 2019
@commodo
Copy link
Contributor Author

commodo commented Jul 25, 2019

Changelog v1 -> v2:

  • don't drop Xcode9
  • update readme & PR with commit README.md: remove OS X El Capitan (10.11) from readme

@commodo
README.md: fix OS X High Sierra alternative package link
cbb29f7 
Was a goof when Xcode 11 support was added.

Fixes: c4833c5  ("build,.travis.yml: add support for Xcode 11")
Signed-off-by: Alexandru Ardelean <[email protected]>
@commodo
Copy link
Contributor Author

commodo commented Jul 25, 2019

Changelog v2 -> v3:

  • fix alternative download link for OS X High Sierra; goofed when added Xcode11 and change that to OS 10.14.4 (from 10.13.6)

@commodo commodo merged commit 915adbb into master Jul 26, 2019
@commodo commodo deleted the drop-xcode9 branch July 26, 2019 05:21
@commodo commodo mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfcollins tfcollins tfcollins approved these changes

@rgetz rgetz Awaiting requested review from rgetz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commodo @rgetz @tfcollins