Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost kernel checks #891

Closed
rgetz opened this issue Aug 29, 2022 · 2 comments · Fixed by #896
Closed

lost kernel checks #891

rgetz opened this issue Aug 29, 2022 · 2 comments · Fixed by #896
Assignees

Comments

@rgetz
Copy link
Contributor

rgetz commented Aug 29, 2022

during a shuffling of the CI directories, CI/travis/check_kernel.sh was removed.

09c0898#diff-a37e1affdcbdf72de04029402805155c7cafde708598281cda8a923c0607e461

now, there is no checking to make sure the libiio enum and struct matches the kernel, which will eventually lead to some problems...

Add the file back:
https://github.com/analogdevicesinc/libiio/blob/5b9ef36ebccfc82533c5dd949b19f8180a751952/CI/travis/check_kernel.sh

and plumb it into the CI, so it works and checks things once per PR. (not on every CI client).

-Robin

@ccraluca
Copy link
Contributor

ccraluca commented Sep 1, 2022

So this script should run on a CI machine for each PR?

In that commit are there other scripts that should not have been deleted?

-Raluca

@rgetz
Copy link
Contributor Author

rgetz commented Sep 1, 2022

So this script should run on a CI machine for each PR?

yes - that is the way it use to work - the CI would make sure the libiio was sync'ed with the kernel on a each PR event - there wasn't any way at the time to do it once a week in a cron or something (and have tests fail) - so it was put into the CI system. If the kernel updates - everyone's PRs fail until it is fixed.

Makes sure that everything is fixed quickly.

In that commit are there other scripts that should not have been deleted?

I don't think so - as long as the other things are working...

@ccraluca ccraluca linked a pull request Sep 5, 2022 that will close this issue
ccraluca pushed a commit that referenced this issue Sep 6, 2022
It checks that the structures defined in iio.h are up-to-date with the
one defined in the kernel's user-space API headers.

Fixes: #891

Signed-off-by: Raluca Chis <[email protected]>
pcercuei pushed a commit that referenced this issue Sep 6, 2022
It checks that the structures defined in iio.h are up-to-date with the
one defined in the kernel's user-space API headers.

Fixes: #891

Signed-off-by: Raluca Chis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants