Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproducible Builds #591

Closed
rgetz opened this issue Sep 17, 2020 · 9 comments
Closed

Reproducible Builds #591

rgetz opened this issue Sep 17, 2020 · 9 comments
Assignees
@rgetz @dNechita

Comments

@rgetz
Copy link
Contributor

rgetz commented Sep 17, 2020

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970498
@rgetz rgetz self-assigned this Sep 17, 2020
@tfcollins
Copy link
Contributor

Anyway for us to test this?

@rgetz
Copy link
Contributor Author

rgetz commented Sep 18, 2020

make two builds - make sure they are identical ?

@mhennerich
Copy link
Contributor

@dNechita can you apply the patch from here:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970498

and test reproducibility?

@dNechita
Copy link
Contributor

Yes, I will test.

@dNechita
Copy link
Contributor

I've tested with the changes in the patch
What the patch does is that allows setting the date during the cmake step. So, if you want to reproduce an identical build with a yesterday build, all you need is to set an environment variable with the yesterday date and then do the build.
Then, the man pages will be identical.

@dNechita
Copy link
Contributor

The idea is to add the changes in the patch to libiio, right?
If so, I'm not sure how to apply the patch (which seems to be a debian diff sort of thing) in order the preserve the original author. Any suggestions?

@rgetz
Copy link
Contributor Author

rgetz commented Sep 28, 2020

I think it is just :
git commit --author="Author Name <[email protected]>"

but you need their permission first. The DCO is per author, and we won't accept anything without a signed-off-by by the original author.

-Robin

lamby added a commit to lamby/libiio that referenced this issue Oct 10, 2020
@lamby
Make the buld reproducible (Closes: analogdevicesinc#591)
7d67064 
Whilst working on the Reproducible Builds effort [0] we noticed that
libiio could not be built reproducibly.

This is because it uses the current build time in the generated
manpages. Patch attached that uses SOURCE_DATE_EPOCH [1].

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/docs/source-date-epoch/
@lamby lamby mentioned this issue Oct 10, 2020
Merged
@lamby
Copy link
Contributor

lamby commented Oct 10, 2020

Added PR. 👍

lamby added a commit to lamby/libiio that referenced this issue Oct 10, 2020
@lamby
Make the build reproducible (Closes: analogdevicesinc#591)
436db24 
Whilst working on the Reproducible Builds effort [0] we noticed that
libiio could not be built reproducibly.

This is because it uses the current build time in the generated
manpages. Patch attached that uses SOURCE_DATE_EPOCH [1].

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/docs/source-date-epoch/

Signed-off-by: Chris Lamb <[email protected]>
@rgetz
Copy link
Contributor Author

rgetz commented Oct 11, 2020

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgetz rgetz

@dNechita dNechita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lamby @tfcollins @rgetz @mhennerich @dNechita