Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library/scripts/adi_ip_xilinx: adi_ip_files update #1543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IstvanZsSzekely
Copy link
Contributor

PR Description

Creates a list for design sources and constraints and then imports all the files at once in their respective category.
A critical warning appeared when importing large amount of files into an IP one by one, as the script was working up until this point. This now creates separate lists after checking the file type and imports all of the files at once. This way the critical warning doesn't appear and the build time is faster as well.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

- Creates a list for design sources and constraints and then imports all the files at once in their respective category

Signed-off-by: Istvan-Zsolt Szekely <[email protected]>
@bluncan bluncan self-requested a review December 13, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants