Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axi_dmac: Fix Intel RAM critical warning #1537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

axi_dmac: Fix Intel RAM critical warning #1537

wants to merge 1 commit into from

Conversation

podgori
Copy link
Contributor

@podgori podgori commented Dec 6, 2024

This commit fixes the critical warning: "mixed_port_feed_through_mode" parameter of RAM atom cannot have value "old" when different read and write clocks are used, by adding a reset on the read side.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@podgori
axi_dmac: Fix Intel RAM critical warning
adb57f8 
This commit fixes the critical warning: "mixed_port_feed_through_mode"
parameter of RAM atom cannot have value "old" when different read and
write clocks are used, by adding a reset on the read side.

Signed-off-by: Ionut Podgoreanu <[email protected]>
@podgori podgori requested a review from sarpadi December 6, 2024 08:05
@podgori podgori requested a review from gastmaier as a code owner December 6, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarpadi sarpadi Awaiting requested review from sarpadi

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@podgori