-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cache Coherency support on Ultrascale projects #1527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is better to have set CACHE_COHERENCY false
set on the common bds instead of having the check if the variable exists condition.
Also, I would revert adi_bd.tcl since ad_mem_hpc0_interconnect ad_mem_hpc1_interconnect methods already exist and the only project that leverages it can call the methods directly without further condition checks.
Hi, can you solve the merge conflict, and establish if this is the final implementation? |
19f10de
to
1e98b22
Compare
V2: Reverted the initial changes on adi_board.tcl and updated the cache coherency enablement per common project as suggested. |
From the ci run:
main run:
locally I get the same results, adrv9009zu11eg.adrv2crr_xmicrowave fails
There is also adrv9009zu11eg.adrv2crr_fmcomms8 2 SUCCESS Failed but looks unrelated (network issue). If it turns out to be unrelated, this should be merged |
1e98b22
to
64ef711
Compare
Signed-off-by: Ionut Podgoreanu <[email protected]>
64ef711
to
629d157
Compare
V3: Rebased on the latest changes on main; fixed adrv9009zu11eg.adrv2crr_xmicrowave timing failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing timing.
The CI status is off because cn0506.zc706 stated failing is passing: /job/main/job/builds/job/main_PR_1527/job/projects/job/cn0506.zc706/
ad_quadmxfe1_ebz.vcu118 was already failling on main
PR Description
This commit enables Cache Coherency on Ultrascale+ projects, leaving it disabled for the other platforms.
PR Type
PR Checklist