Fix deadlock when checking whether to send keep alive

anacrolix · Aug 19, 2021 · 16c4b08 · 16c4b08
1 parent a3c2d76
commit 16c4b08
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/peer-conn-msg-writer.go b/peer-conn-msg-writer.go
@@ -79,14 +79,16 @@ func (cn *peerConnMsgWriter) run(keepAliveTimeout time.Duration) {
 		if cn.closed.IsSet() {
 			return
 		}
+		keepAlive := false
 		if cn.writeBuffer.Len() == 0 {
 			func() {
 				cn.mu.Unlock()
 				defer cn.mu.Lock()
 				cn.fillWriteBuffer()
+				keepAlive = cn.keepAlive()
 			}()
 		}
-		if cn.writeBuffer.Len() == 0 && time.Since(lastWrite) >= keepAliveTimeout && cn.keepAlive() {
+		if cn.writeBuffer.Len() == 0 && time.Since(lastWrite) >= keepAliveTimeout && keepAlive {
 			cn.writeBuffer.Write(pp.Message{Keepalive: true}.MustMarshalBinary())
 			torrent.Add("written keepalives", 1)
 		}